Skip to content

Web: add support for more RawWindowHandle variants #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2023
Merged

Web: add support for more RawWindowHandle variants #188

merged 2 commits into from
Dec 17, 2023

Conversation

@daxpedda
Copy link
Member

@daxpedda daxpedda commented Dec 17, 2023

This adds support for RawWindowHandle::WebCanvas and RawWindowHandle::WebOffscreenCanvas.

@daxpedda daxpedda added the Web label Dec 17, 2023
@daxpedda daxpedda requested a review from john01dav as a code owner December 17, 2023 22:26
notgull
notgull approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@daxpedda daxpedda merged commit 4e8735c into rust-windowing:master Dec 17, 2023
@daxpedda daxpedda mentioned this pull request Dec 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notgull notgull notgull approved these changes

@john01dav john01dav Awaiting requested review from john01dav

Assignees

No one assigned

Labels

Web

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daxpedda @notgull