2.0.2: Mission Control dragging toggle appears inverted

[aketurbal]

Hi! While reviewing Rectangle 2.0.2 (109), I noticed a possible mismatch between the Mission Control dragging toggle's label and its state. This is a static code observation; I have not reproduced it in the UI.

In SnapAreaSettingsView.swift, the toggle labelled "Mission Control dragging" is bound to missionControlDraggingDisabled and is only displayed while that value is true. The property's didSet stores the inverse value in Defaults.missionControlDragging.enabled.

Based on this code, the toggle appears to be on when Mission Control dragging is disabled. Switching it off would enable the behaviour and make the toggle disappear.

Is this intended? It looks as though the label, binding and visibility condition may need to be aligned. If the toggle controls disabling the behaviour, an explicit negative label could help.

Source:

Rectangle/Rectangle/SettingsWindow/SnapAreaSettingsView.swift

Line 176 in c0ae7f8

if viewModel.missionControlDraggingDisabled {

The corresponding property observer is at lines 75–79 in the same file.

Thank you!

[rxhanson]

This toggle never followed convention, and might no longer be used because modern versions of macOS made it more difficult to trigger Mission Control. Regardless, I've checked in a change that communicates the behavior of the UI more effectively and has correct logic.