Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Potential clash between an existing ID and the randomly generated ID #21

Closed
gamov opened this Issue · 3 comments

2 participants

@gamov

Hello,
this is more a concern than an issue.

I'm wondering what happens if the ID generated by:
var new_id = new Date().getTime();
content = content.replace(regexp, new_id);
end up being an existing record id in the DB. Wouldn't it be mistakenly erased by this new record?

@ryanb
Owner

That's a good question. I believe it will update the items in the existing record assuming they belong_to the same parent record. I forget if adding alpha characters into a new id will cause any problems. If not it may be worth keeping the new_ prefix that it replaces.

The ID is very large and like I said I think it has to match the same parent, so the chances of there being a conflict are very slim. Still would be nice to fix though.

@ryanb
Owner

prefix new record ids with new_ to ensure there's no conflict with existing records - closed by c3e667f

@ryanb ryanb closed this
@gamov

Excellent idea, that's nice to see Rails handling this nicely

@dima4p dima4p referenced this issue from a commit in dima4p/nested_form
@ryanb prefix new record ids with new_ to ensure there's no conflict with ex…
…isting records - closes #21
c3e667f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.