Skip to content

Review Queue

Ryan Cole edited this page Nov 14, 2026 · 1 revision

Anything pbeta isn't sure about becomes a review item instead of a guess. You decide it; the next repair --store honors the decision.

Commands default to --store .pbeta/store.json. Pass the same store you gave repair.

List

pbeta review list --store store.json          # open items; exit code 1 if any
pbeta review list --store store.json --all    # decided ones too
ChecksumBlock:111111111111:222222222222 [open]
  reason: ambiguous
  old:    0x1400
  detail: 2 functions in the new build are equally plausible (0x2500, 0x2700); the engine will not pick one
  candidate 0x2500     accepted       via normalized-hash (score 0.00)
  candidate 0x2700     accepted       via normalized-hash (score 0.00)

The id is <hook>:<old build>:<new build> (builds shortened).

Reasons

Reason What to do
unmatched No candidate. Find it yourself and accept --function, or try the AI Proposer.
ambiguous Several equally plausible. Compare them (in Ghidra, IDA or a debugger) and accept one.
verification_failed A candidate failed checks. Accepting one that verification rejected needs --force.
insufficient_evidence Checks passed, but the hook's criticality needs more, often a behavioral pass (Behavioral Evidence).
signature_changed Matched, but parameters changed. The item has a proposed prototype and shim; update your detour, then accept.
struct_layout_changed A struct in the prototype changed. The item has the new layout and offsets.
not_hookable The new function is under 5 bytes, a branch targets its first bytes, or it's only a jump thunk.
stale_locator The hook is bound to another build. Repair again with --earlier <that build's analysis>.
ai_proposal A proposal from the AI Proposer or an agent through the MCP Server, already verified. Accept or reject it like any candidate.

Decide

# This candidate is the counterpart
pbeta review accept <id> --candidate 0x2700 --reviewer you --store store.json

# A function that isn't among the candidates (verified first, like any candidate)
pbeta review accept <id> --function 0x2a40 --old-analysis old.json --new-analysis new.json --reviewer you --store store.json

# None of the candidates is the counterpart; they're never proposed for it again
pbeta review reject <id> --reviewer you --note "both are wrappers" --store store.json

# Withdraw an acceptance; the item reopens
pbeta review revoke <id> --reviewer you --store store.json

--candidate is required when an item has more than one. A candidate verification rejected needs --force. Every decision is recorded with the reviewer and note, append-only.

Then repair again with the same --store.

Other ways to review

  • Ghidra Integration: a review window beside the listing and decompiler, with side-by-side comparison.
  • MCP Server: an agent can read and explain items, and add proposals. It can't accept.
  • pbeta mappings --old old.json --new new.json --store store.json lists every accepted mapping for a build pair and why each other function is pending.

Clone this wiki locally