-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cascadia Code to font sources #374
Conversation
The font patcher will need to be updated to add an additional rule for this font to comply with the license https://github.com/ryanoasis/nerd-fonts/blob/master/font-patcher#L310 as Cascadia Code is a reserved font name. |
Can we call it "Waterfallia Code"? |
Caskaydia? |
I pinged a MS program manage to see if she has a suggestion for an alternate name (there was a twitter poll with several other options) or if a license exception could be made for the nerd fonts distribution. |
See also the discussion in the upstream repository: microsoft/cascadia-code#10 (comment) |
How about ... |
@@ -0,0 +1,94 @@ | |||
Copyright (c) 2019 - Present, Microsoft Corporation, | |||
with Reserved Font Name Cascadia Code. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/unpatched-fonts/CascadiaCode/Cascadia.ttf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GhosT02101991 what does this mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that the font can be changed, but any modified font could not use the name Cascadia Code, as looks like it is MS Trademark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I guess I was confused why it was being pointed out. Yeah the name needs to be respected due to RFN
The patched Cascadia font has issues...
These issues (including patching the |
Add Cascadia Code to font sources
Description
This adds a new font from Microsoft, Cascadia Code.
I was unable to run the patch all the fonts script on Windows and with WSL, I think due to some issues with FontForge not shipping a Python module? 🤷♂
Requirements / Checklist
./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
./gotta-patch-em-all-font-patcher\!.sh Hermit
TODO: As I was unable to generate new patched fonts, I did not extend the readme with a broken link to a patched font.
What does this Pull Request (PR) do?
This adds the source files for Cascadia Code.
How should this be manually tested?
I ran font-patcher manually with a variety of options and verified the font renders correctly:
What are the relevant tickets (if any)?
#373
Screenshots (if appropriate or helpful)