Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cascadia Code to font sources #374

Merged
merged 1 commit into from
Dec 22, 2019

Conversation

AaronFriel
Copy link

@AaronFriel AaronFriel commented Sep 19, 2019

Description

This adds a new font from Microsoft, Cascadia Code.

I was unable to run the patch all the fonts script on Windows and with WSL, I think due to some issues with FontForge not shipping a Python module? 🤷‍♂

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

TODO: As I was unable to generate new patched fonts, I did not extend the readme with a broken link to a patched font.

What does this Pull Request (PR) do?

This adds the source files for Cascadia Code.

How should this be manually tested?

I ran font-patcher manually with a variety of options and verified the font renders correctly:

image

What are the relevant tickets (if any)?

#373

Screenshots (if appropriate or helpful)

image

@nogweii
Copy link
Collaborator

nogweii commented Sep 19, 2019

The font patcher will need to be updated to add an additional rule for this font to comply with the license https://github.com/ryanoasis/nerd-fonts/blob/master/font-patcher#L310 as Cascadia Code is a reserved font name.

@LuRsT
Copy link
Collaborator

LuRsT commented Sep 20, 2019

Can we call it "Waterfallia Code"?

@jmickey
Copy link

jmickey commented Sep 20, 2019

Caskaydia?

@AaronFriel
Copy link
Author

I pinged a MS program manage to see if she has a suggestion for an alternate name (there was a twitter poll with several other options) or if a license exception could be made for the nerd fonts distribution.

@nogweii
Copy link
Collaborator

nogweii commented Sep 21, 2019

See also the discussion in the upstream repository: microsoft/cascadia-code#10 (comment)

@rivy
Copy link

rivy commented Sep 28, 2019

How about ...
Cascodia PF for powerline-only addition
Cascodia NF for full nerd-font treatment
?

@@ -0,0 +1,94 @@
Copyright (c) 2019 - Present, Microsoft Corporation,
with Reserved Font Name Cascadia Code.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/unpatched-fonts/CascadiaCode/Cascadia.ttf

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GhosT02101991 what does this mean?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the font can be changed, but any modified font could not use the name Cascadia Code, as looks like it is MS Trademark

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I guess I was confused why it was being pointed out. Yeah the name needs to be respected due to RFN

@Finii
Copy link
Collaborator

Finii commented Oct 24, 2019

The patched Cascadia font has issues...

  • If you patch the CascadiaCode 1910.04 the patched font is not detected as monospaced by Windows anymore, while the original is.
  • This means you need to use --mono, which breaks the font because of bugs? in font-patcher: Composite glyhs like Ä U+00C4 have the added diacritics in the wrong position:

Selection_246

These issues (including patching the font-patcher) have been fixed at https://github.com/adam7/delugia-code
I will prepare a PR to get the script fixes here.

@Finii Finii mentioned this pull request Oct 24, 2019
5 tasks
@ryanoasis ryanoasis added this to the v2.1.0 milestone Dec 22, 2019
@ryanoasis ryanoasis merged commit 3f50100 into ryanoasis:master Dec 22, 2019
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants