Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum required pytest version #86

Closed
macropin opened this issue Feb 21, 2019 · 2 comments
Closed

Update minimum required pytest version #86

macropin opened this issue Feb 21, 2019 · 2 comments
Labels

Comments

@macropin
Copy link

macropin commented Feb 21, 2019

The tests are failing with the following error with the 3.0 release:

============================= test session starts ==============================
platform linux -- Python 3.5.3, pytest-3.0.6, py-1.4.32, pluggy-0.4.0 -- /usr/bin/python3
cachedir: tests/.cache
rootdir: /tmp/tmp.2ZPMsLJWjt/tests, inifile: pytest.ini
plugins: catchlog-1.2.2
collecting ... 
==================================== ERRORS ====================================
_______________________ ERROR collecting t1_backends.py ________________________
tests/t1_backends.py:113: in pytest_generate_tests
    with_backend_mark = metafunc.definition.get_closest_marker('with_backend')
E   AttributeError: 'Metafunc' object has no attribute 'definition'
!!!!!!!!!!!!!!!!!!!! Interrupted: stopping after 1 failures !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 1.21 seconds ============================
The command '/bin/sh -c /build-s3ql.sh' returned a non-zero code: 2
make: *** [build] Error 2

See https://github.com/panubo/docker-s3ql/blob/master/build-s3ql.sh for the complete installation / build script.

@Nikratio
Copy link
Collaborator

Thanks for the report! Please use pytest 4.x

@Nikratio Nikratio changed the title Test Failure: AttributeError: 'Metafunc' object has no attribute 'definition' Update minimum required pytest version Feb 25, 2019
@Nikratio Nikratio added the bug label Feb 25, 2019
@macropin
Copy link
Author

Thanks. This is confirmed. Pytest 4.x works.

May I suggest the following:

  • Update the documentation currently it reads "pytest, version 2.7 or newer (optional, to run unit tests)"
  • Please consider adding the test requirements ie tests_require to setup.py and defining the test suite entry point there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants