Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method -> algorithm, part 3 #19572

Closed
jm58660 mannequin opened this issue Nov 12, 2015 · 12 comments
Closed

method -> algorithm, part 3 #19572

jm58660 mannequin opened this issue Nov 12, 2015 · 12 comments

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Nov 12, 2015

Rename keyword method to algorithm like in #6094 years ago. Files to change:

src/sage/combinat/alternating_sign_matrix.py
src/sage/combinat/cluster_algebra_quiver/cluster_seed.py
src/sage/libs/fplll/fplll.pyx
src/sage/modular/modform_hecketriangle/hecke_triangle_groups.py
src/sage/modular/modform_hecketriangle/hecke_triangle_group_element.py

Files to check

src/sage/combinat/designs/covering_design.py
src/sage/combinat/words/word_generators.py -> construction_method?
src/sage/combinat/e_one_star.py
src/sage/misc/misc.py

Parts 1 and 2 are #19550 and #19559.

Component: misc

Author: Jori Mäntysalo

Branch/Commit: d0ce399

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/19572

@jm58660 jm58660 mannequin added this to the sage-6.10 milestone Nov 12, 2015
@jm58660 jm58660 mannequin added p: minor / 4 labels Nov 12, 2015
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Nov 18, 2015

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Nov 18, 2015

Commit: de60a34

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Nov 18, 2015

comment:2

Some functions again converted from method= to algorithm=.


New commits:

de60a34From 'method' to 'algorithm'

@jm58660 jm58660 mannequin added the s: needs review label Nov 18, 2015
@jdemeyer
Copy link

comment:3

Author name please...

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Nov 23, 2015

comment:4

Replying to @jdemeyer:

Author name please...

Duh. Sorry.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Nov 23, 2015

Author: Jori Mäntysalo

@jdemeyer
Copy link

comment:5

Why this as only change in this file?

diff --git a/src/sage/modular/modform_hecketriangle/hecke_triangle_groups.py b/src/sage/modular/modform_hecketriangle/hecke_triangle_groups.py
index 64c3e15..89ad904 100644
--- a/src/sage/modular/modform_hecketriangle/hecke_triangle_groups.py
+++ b/src/sage/modular/modform_hecketriangle/hecke_triangle_groups.py
@@ -30,6 +30,7 @@ from sage.misc.cachefunc import cached_method
 
 from hecke_triangle_group_element import HeckeTriangleGroupElement, cyclic_representative, coerce_AA
 
+from sage.misc.decorators import rename_keyword
 
 class HeckeTriangleGroup(FinitelyGeneratedMatrixGroup_generic, UniqueRepresentation):
     r"""

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 25, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

d0ce399Removed unnecessary import.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 25, 2015

Changed commit from de60a34 to d0ce399

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Nov 25, 2015

comment:7

Replying to @jdemeyer:

Why this as only change in this file?

I don't know. Maybe my brain was overheated or something. Removed.

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@vbraun
Copy link
Member

vbraun commented Nov 26, 2015

Changed branch from u/jmantysalo/method____algorithm__part_3 to d0ce399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants