Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script packages build/pkgs/_prereq, build/pkgs/_bootstrap #29124

Closed
mkoeppe opened this issue Jan 31, 2020 · 91 comments
Closed

Add script packages build/pkgs/_prereq, build/pkgs/_bootstrap #29124

mkoeppe opened this issue Jan 31, 2020 · 91 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 31, 2020

As a follow-up to #29053, we move the build/pkgs/*.txt files to a more systematic location. This will simplify some scripts.

  • build/pkgs/_prereq/distros/debian.txt etc. - records the minimal requirements (system packages) for installing from source. (we move the current build/pkgs/debian.txt etc. there)
  • build/pkgs/_bootstrap/distros/debian.txt etc. - would record the additional requirements for running ./bootstrap (we move the current build/pkgs/debian-bootstrap.txt there)

Related:

Possible follow-up:

  • build/pkgs/_toolchain/dependencies - to replace some special Makefile targets currently in build/make/Makefile.in.

Depends on #30940
Depends on #29655

CC: @dimpase @egourgoulhon @jhpalmieri @kiwifb @tobiasdiez @seblabbe @slel @kliem

Component: build

Keywords: sd111

Author: Matthias Koeppe

Branch/Commit: e8da106

Reviewer: Sébastien Labbé, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29124

@mkoeppe mkoeppe added this to the sage-9.1 milestone Jan 31, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Add script packages build/pkgs/PREREQ, build/pkgs/TOOLCHAIN, build/pkgs/BOOTSTRAP Add script packages build/pkgs/_prereq, build/pkgs/_toolchain, build/pkgs/_bootstrap Feb 7, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 14, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 15, 2020

comment:4

for example on fedora-26-standard sagetex testsuite fails:

! LaTeX Error: File `makecmds.sty' not found.

Type X to quit or <RETURN> to proceed,
or enter new name. (Default extension: sty)

Enter file name: 
! Emergency stop.
<read *> 
         
l.78 \RequirePackage
                    {ifpdf}^^M

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Add script packages build/pkgs/_prereq, build/pkgs/_toolchain, build/pkgs/_bootstrap Add script packages build/pkgs/_prereq, build/pkgs/_toolchain, build/pkgs/_bootstrap, _recommended Apr 15, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 16, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 16, 2020

Commit: bf2dfdf

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 16, 2020

comment:6

Installation manual also recommends Tcl/Tk - what are they used for in Sage?
http://doc.sagemath.org/html/en/installation/source.html#tcl-tk


New commits:

bf2dfdfbuild/pkgs/_recommended: New

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 16, 2020

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Add script packages build/pkgs/_prereq, build/pkgs/_toolchain, build/pkgs/_bootstrap, _recommended Add script packages build/pkgs/_prereq, build/pkgs/_toolchain, build/pkgs/_bootstrap Apr 23, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 23, 2020

Dependencies: #29557

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 23, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 23, 2020

Changed commit from bf2dfdf to none

@egourgoulhon

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Aug 13, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 23, 2020

Changed dependencies from #29557 to #30951

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 23, 2020

comment:14

Best done on top of #30951

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 24, 2020

Changed dependencies from #30951 to #30951, #30947

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Add script packages build/pkgs/_prereq, build/pkgs/_toolchain, build/pkgs/_bootstrap Add script packages build/pkgs/_prereq, build/pkgs/_bootstrap Nov 24, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 2, 2021

Changed dependencies from #30940 to #30940, #29655

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 2, 2021

Changed commit from 9988c5f to 6ff6545

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 2, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

6f3b864build/pkgs/[s-t]*/SPKG.rst: Reformat title in format 'spkg_name: Short description'
23558f8build/pkgs/[t-z]*/SPKG.rst: Reformat title in format 'spkg_name: Short description' -- completes coverage of all standard packages
17789dfbuild/pkgs/[z-z]*/SPKG.rst: Reformat title in format 'spkg_name: Short description' -- completes coverage of all optional packages
944408dbuild/pkgs/[a-z]*/SPKG.rst: Reformat title in format 'spkg_name: Short description' -- completes coverage of all experimental packages
feafa60src/doc/en/installation/standard_packages.rst: Remove
58c63e1src/doc/bootstrap: Add brief explanation of the standard/optional/experimental package types
54d4fb1extra line after version
17f2f24Merge branch 't/29655/improve_build_pkgs___spkg_rst' into t/29124/script-packages-prereq-toolchain-bootstrap
e7a768bbuild/pkgs/{_bootstrap,_prereq}/SPKG.rst: Reformat title
6ff6545Move build/pkgs/opensuse*.txt to build/pkgs/{_bootstrap,_prereq}/distros

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 2, 2021

comment:64

Still needs review

@dimpase
Copy link
Member

dimpase commented Jan 3, 2021

comment:65

./bootstrap is getting very slow - 3 times slower than ./configure, over 60 sec on a relatively fast machine!

@dimpase
Copy link
Member

dimpase commented Jan 3, 2021

comment:66

On this branch I'm getting

sage -t --warn-long 53.2 --random-seed=0 src/sage/tests/cmdline.py
**********************************************************************
File "src/sage/tests/cmdline.py", line 219, in sage.tests.cmdline.test_executable
Failed example:
    print(out)  # optional - build
Expected:
    Found local metadata for sqlite-...
    SQLite
    ======
    ...
    SQLite is a software library that implements a self-contained,
    serverless, zero-configuration, transactional SQL database engine.
    ...
Got:
    sqlite: An SQL database engine
    ==============================
    <BLANKLINE>
    Description
    -----------
    <BLANKLINE>
    SQLite is a software library that implements a self-contained,
    serverless, zero-configur
...

and one more similar failure in this file.
Not sure whether it's coming from this ticket, or one of dependencies.

@dimpase
Copy link
Member

dimpase commented Jan 3, 2021

Changed reviewer from Sébastien Labbé to Sébastien Labbé, Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 3, 2021

comment:67

Thanks for catching this. It's coming from #29655

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2021

Changed commit from 6ff6545 to b57fecc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

2eac7a1src/doc/bootstrap: Use sage-spkg-info directly instead of 'sage --info', much faster now
3fe8d4csrc/sage/tests/cmdline.py: Adjust doctests
b57feccMerge branch 't/29655/improve_build_pkgs___spkg_rst' into t/29124/script-packages-prereq-toolchain-bootstrap

@dimpase
Copy link
Member

dimpase commented Jan 4, 2021

comment:70

hmm, now I see

File "src/sage/tests/cmdline.py", line 219, in sage.tests.cmdline.test_executable
Failed example:
    print(out)  # optional - build
Expected:
    SQLite
    ======
    ...
    SQLite is a software library that implements a self-contained,
    serverless, zero-configuration, transactional SQL database engine.
    ...
Got:
    sqlite: An SQL database engine
    ==============================
    <BLANKLINE>
    Description
    -----------
    <BLANKLINE>
    SQLite is a software library that implements a self-contained,
    serverless, zero-configuration, transactional SQL database engine.
    <BLANKLINE>
...

(and the same in line 232)

So more changes of these test outputs are needed.

The different heading (sqlite: An SQL database engine) comes from src/doc/en/reference/spkg/sqlite.rst, as far as me and grep can tell.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

49ad8aesrc/sage/tests/cmdline.py: Adjust doctest properly
e8da106Merge branch 't/29655/improve_build_pkgs___spkg_rst' into t/29124/script-packages-prereq-toolchain-bootstrap

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2021

Changed commit from b57fecc to e8da106

@dimpase
Copy link
Member

dimpase commented Jan 4, 2021

comment:73

OK, good.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 5, 2021

comment:74

Thanks!

@vbraun
Copy link
Member

vbraun commented Jan 24, 2021

Changed branch from u/mkoeppe/script-packages-prereq-toolchain-bootstrap to e8da106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants