Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script package _recommended and generate "recommended system packages" info #29557

Closed
mkoeppe opened this issue Apr 23, 2020 · 65 comments
Closed

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 23, 2020

Let's improve the installation-from-source documentation regarding the "recommended system packages" for 9.1.

(from #29124)

Related:

CC: @egourgoulhon @dimpase @kiwifb @orlitzky @jhpalmieri @videlec @kcrisman @slel @antonio-rojas @kliem @thierry-FreeBSD @saraedum

Component: documentation

Keywords: sd109

Author: Matthias Koeppe, John Palmieri

Branch: 6d5cc43

Reviewer: John Palmieri, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29557

@mkoeppe mkoeppe added this to the sage-9.1 milestone Apr 23, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 23, 2020

Branch: u/mkoeppe/29557-recommended-packages

@egourgoulhon
Copy link
Member

Commit: 449df5a

@egourgoulhon
Copy link
Member

New commits:

449df5abuild/pkgs/_recommended: New

@egourgoulhon

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 24, 2020

comment:4

So far we only have the recommended packages for debian/ubuntu

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 25, 2020

Dependencies: #29558

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

66c07d8trac 29558: first draft
deb84cdsage-print-system-package-command: More options, update uses
a832dbcsrc/doc/bootstrap: Initialize OPTIONAL_SYSTEM_PACKAGES
272f01bbuild/bin/sage-spkg: Update use of sage-print-system-package-command
8f064f4trac 29558: correct some markup, change the date at end of file
8273e84build/pkgs/_recommended: New

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Changed commit from 449df5a to 8273e84

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

7151382src/doc/bootstrap: Generate debian-recommended.txt etc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Changed commit from 8273e84 to 7151382

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 25, 2020

comment:9

Would someone like to help with the list of packages on their favorite distribution?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 25, 2020

Author: Matthias Koeppe

@jhpalmieri
Copy link
Member

@jhpalmieri
Copy link
Member

Changed commit from 7151382 to 85281cf

@jhpalmieri
Copy link
Member

comment:12

Here are a few suggestions for homebrew.


New commits:

85281cftrac 29557: some recommended packages for homebrew

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2104e53trac 29557: some recommended packages for homebrew

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Changed commit from 85281cf to 2104e53

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 25, 2020

comment:14

I don't think gcc needs to be added here - it's already listed in build/pkgs/gfortran/distros/homebrew.txt

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8550fe0trac 29557: some recommended packages for homebrew

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2020

Changed commit from 2104e53 to 8550fe0

@jhpalmieri
Copy link
Member

comment:16

Okay, I took gcc out.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 25, 2020

comment:17

Thanks!

@kliem
Copy link
Contributor

kliem commented Apr 28, 2020

comment:18

Typo in the ubuntu link:

+https://wiki.sagemath.org/prerequisites/Ubuntu
-https://wiki.sagemath.org/prerequisitesUbuntu

@slel
Copy link
Member

slel commented Apr 28, 2020

comment:19

My fault: I recently moved that page from prerequisitesUbuntu
to prerequisites/Ubuntu to make it easier to find, better indexed,
and thinking we might have other prerequisites/something.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 28, 2020

comment:20

Replying to @slel:

[...] thinking we might have other prerequisites/something.

Hopefully this won't be necessary and we can keep this information up to date in a single place - the install manual.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 4, 2020

Changed author from Matthias Koeppe to Matthias Koeppe, John Palmieri

@slel
Copy link
Member

slel commented Oct 19, 2020

comment:39

What commit are you working on top of?

What does git log --oneline -20 say (or -3 if it's enough)?

@jhpalmieri
Copy link
Member

comment:40
6d5cc43d09 (HEAD -> t/29557/29557-recommended-packages) trac 29557: recommended packages for homebrew
d198e9c5b7 build/pkgs/_recommended/distros/debian.txt: Format change
fe9ba0b00c build/pkgs/_recommended/distros/homebrew.txt: New
ea5d610b21 src/doc/bootstrap: Generate debian-recommended.txt etc
2cd5ef99ee build/pkgs/_recommended: New

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 20, 2020

comment:41

go for the force push. It's possible that you had a branch under your name previously that can't be fast-forwarded

@jhpalmieri
Copy link
Member

@jhpalmieri
Copy link
Member

comment:43

Replying to @mkoeppe:

go for the force push. It's possible that you had a branch under your name previously that can't be fast-forwarded

Done


New commits:

6d5cc43trac 29557: recommended packages for homebrew

@jhpalmieri
Copy link
Member

Changed commit from d198e9c to 6d5cc43

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 20, 2020

comment:45

We could update the installation manual, in src/doc/en/installation/source.rst, using the generated files, but probably it's best to leave this for another ticket.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 20, 2020

Reviewer: ..., Matthias Koeppe

@jhpalmieri
Copy link
Member

Changed reviewer from ..., Matthias Koeppe to John Palmieri, Matthias Koeppe

@jhpalmieri
Copy link
Member

comment:47

This looks good to me, although I can't really vouch for the recommendations on debian. It's certainly a good start, and people can supplement on later tickets.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.2 Oct 20, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@vbraun
Copy link
Member

vbraun commented Oct 31, 2020

Changed branch from u/jhpalmieri/29557-recommended-packages to 6d5cc43

@jhpalmieri
Copy link
Member

comment:51

On OS X, I see this:

configure:40015: notice: the following SPKGs did not find equivalent system packages: _recommended arb brial cbc cddlib cliquer cmake coxeter3 eclib ecm fflas_ffpack flint flintqs fplll gf2x gfan giac givaro gp2c iml lcalc libbraiding libsemigroups lrcalc m4ri m4rie ntl palp pari pari_elldata pari_galdata pari_galpol pari_nftables pari_seadata pari_seadata_small perl_cpan_polymake_prereq perl_term_readline_gnu planarity rw symmetrica sympow tachyon zn_poly
configure:40017: checking for the package system in use
configure:40020: result: homebrew
configure:40029: hint: installing the following system packages is recommended and may avoid building some of the above SPKGs from source:
configure:40031:   $ brew install pandoc ffmpeg imagemagick texinfo cmake

On a follow-up, we could improve this message. First, these recommended packages don't actually help to avoid building any of the listed SPKGs. Second, this message is printed regardless of whether ffmpeg et al. are installed. Third, I actually have pandoc installed, it is correctly detected by ./configure, but it recommends installing it anyway.

@jhpalmieri
Copy link
Member

Changed commit from 6d5cc43 to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 1, 2020

comment:52

Note there's also a separate pandoc script package

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 1, 2020

comment:53

For improvements of this type, please see #29146, #29372

@jhpalmieri
Copy link
Member

comment:54

Replying to @mkoeppe:

Note there's also a separate pandoc script package

Right, and that correctly detects my pandoc installation, so it would be nice if the ending message took that into account. The ending message automatically prints every recommended external package, even those which are installed and have corresponding script packages.

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Nov 2, 2020

comment:55

Replying to jhpalmieri (comment 51):

On a follow-up, we could improve this message. First, these recommended
packages don't actually help to avoid building any of the listed SPKGs.
Second, this message is printed regardless of whether ffmpeg et al.
are installed. Third, I actually have pandoc installed, it is correctly
detected by ./configure, but it recommends installing it anyway.

See:

@tobiasdiez
Copy link
Contributor

comment:56

The package texlive-generic-extra doesn't exist for ubuntu 20.04, and on 18.04 it was already labeled as "transitional dummy package". I'm not sure what's the correct replacement, maybe simply "texlive"?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

comment:57

Follow-up regarding the package list at #30930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants