Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage --package download is broken #30648

Closed
seblabbe opened this issue Sep 23, 2020 · 12 comments
Closed

sage --package download is broken #30648

seblabbe opened this issue Sep 23, 2020 · 12 comments

Comments

@seblabbe
Copy link
Contributor

$ sage --package download cbc
Traceback (most recent call last):
  File "/home/slabbe/GitBox/sage/build/bin/sage-package", line 42, in <module>
    run()
  File "/home/slabbe/GitBox/sage/build/bin/../sage_bootstrap/cmdline.py", line 318, in run
    app.download_cls(args.package_name, args.allow_upstream)
TypeError: download_cls() takes exactly 2 arguments (3 given)

Component: distribution

Author: Sébastien Labbé

Branch: e463513

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30648

@seblabbe seblabbe added this to the sage-9.2 milestone Sep 23, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 23, 2020

comment:1

Looks like I broke this when adding the upstream_url feature. I'll looking into fixing it

@seblabbe
Copy link
Contributor Author

comment:2

doing this change:

- app.download_cls(args.package_name, args.allow_upstream)
+ app.download(args.package_name, args.allow_upstream)

fixed it on my side

@seblabbe
Copy link
Contributor Author

comment:3

I don't know if this is the correct fix.

I don't know if there are similar error in the file.

I just know that this change allowed me to download the tarball I was looking for.


New commits:

e46351330648: download_cls -> download

@seblabbe
Copy link
Contributor Author

Author: Sébastien Labbé

@seblabbe
Copy link
Contributor Author

Commit: e463513

@seblabbe
Copy link
Contributor Author

Branch: u/slabbe/30648

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@seblabbe
Copy link
Contributor Author

seblabbe commented Nov 2, 2020

comment:5

a gentle ping

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 2, 2020

Reviewer: Matthias Koeppe

@seblabbe
Copy link
Contributor Author

seblabbe commented Nov 3, 2020

comment:7

thanks for the review

@vbraun
Copy link
Member

vbraun commented Nov 15, 2020

Changed branch from u/slabbe/30648 to e463513

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 19, 2020

comment:9

Follow-up in #30865

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 19, 2020

Changed commit from e463513 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants