-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage_bootstrap: Update/extend "sage -package", fix "make download" #30865
Comments
comment:1
Developers interested in improving the system package advice may want to work on this ticket |
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
Commit: |
This comment has been minimized.
This comment has been minimized.
Dependencies: #30648 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:13
Ready for review |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:16
The current branch is doing this: - def download_cls(self, package_name_or_class):
+ def download_cls(self, package_name_or_class, allow_upstream=False): So should the change I made in #30648 be reverted then? (I recall that the problem fixed in #30648 was that |
comment:17
Doing
So using So I would suggest the following change: - self.names += [package_name_or_class]
+ self.names.append(package_name_or_class) as well as (5 times): - self.names += [pkg.name for pkg in Package.all() if predicate(pkg)]
+ self.names.extend(pkg.name for pkg in Package.all() if predicate(pkg)) |
comment:31
Replying to @seblabbe:
This is referring to https://doc.sagemath.org/html/en/developer/packaging.html#package-source-types |
comment:32
Replying to @seblabbe:
I have made a similar change in the above commit.
Yes, this is a feature, and the above commit documents it. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:35
Replying to @mkoeppe:
Well, I first did
Great. Thank you. |
comment:36
Thanks for the answers and commits, I will check this tomorrow morning Bordeaux time. [I think my comment (3) is still not fixed (well, it is just a small detail).] |
comment:37
Replying to @seblabbe:
That should actually work too. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:39
Replying to @mkoeppe:
Ok, I see. But after
|
comment:40
Actually, it did not get stuck, but I obtain three errors after few minutes:
After that it seems tox does the same with other version of Python it finds on the system. With python 3.6, it returns two errors instead of three (the Let me now check whether this is related to the current ticket or not by rerunning it after a |
comment:41
I also get errors with 9.3.beta1, but not exactly the same.
I don't know how much this is related to the current ticket. From my point of view, I give a positive review to the commits done up to now. Matthias, I let you change the status to positive review if you think the tox issues are unrelated or if they can be dealt in another ticket. |
comment:42
Thank you! (I also get the additional |
This comment has been minimized.
This comment has been minimized.
Changed branch from u/mkoeppe/sage_bootstrap__update_extend_system_package_tools to |
comment:45
I tried Which is expected. Indeed, reading from the last scipoptsuite ticket:
How do we deal with that? |
Changed commit from |
(from #29146, #30861)
There are several places where the spkg (
build/pkgs/*/
) and system package information (build/pkgs/*/distros/*.txt
) is parsed:bootstrap
src/doc/bootstrap
build/bin/write_dockerfile.sh
build/bin/sage-get-system-packages
tox.ini
(forlocal-homebrew
,local-conda
).github/workflows/ci-wsl.yml
(using powershell)src/bin/sage-download-upstream
m4/sage_spkg_*.m4
The purpose of this ticket is to prepare refactoring of this code by extending the
sage_bootstrap
package.sage_bootstrap.package
so that it understands non-normal packages (i.e., script and pip packages, which do not havechecksums.ini
)sage -package list
so it supports the following invocations:sage -package list :standard: :optional:
(several "classes" (types), not just one)sage -package list --has-file=spkg-configure.m4 :standard:
(needed forbootstrap
,src/doc/bootstrap
)sage -package list --has-file=spkg-configure.m4 --has-file=distros/debian.txt :standard: :optional:
(needed forbuild/bin/write-dockerfile.sh
,tox.ini
)sage -package list --has-file=SPKG.rst :all:
(needed forsrc/doc/bootstrap
)sage -package download
(follow up from sage --package download is broken #30648) so it supportssage -package download :all:
(again - was broken)sage -package download --allow-upstream :all:
(allows retrieving fromupstream_url
)and use it for
make download
(fix make download #29896), removingsrc/bin/sage-download-upstream
To run the testsuite of
sage_bootstrap
, useFollow-up:
sage -package list --not-source=pip :optional: :experimental:
(would simplifybootstrap
)Depends on #30648
CC: @seblabbe @tobiasdiez @slel @jhpalmieri @vbraun
Component: build: configure
Author: Matthias Koeppe
Branch:
f33c363
Reviewer: Sébastien Labbé
Issue created by migration from https://trac.sagemath.org/ticket/30865
The text was updated successfully, but these errors were encountered: