-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix make download #29896
Comments
comment:2
One option: diff --git a/Makefile b/Makefile
index 822d1d316f..74863704b1 100644
--- a/Makefile
+++ b/Makefile
@@ -61,9 +61,9 @@ buildbot-python3:
$(MAKE)
# Preemptively download all standard upstream source tarballs.
-download:
+download: build/make/Makefile
export SAGE_ROOT=$$(pwd) && \
- export PATH=$$SAGE_ROOT/src/bin:$$PATH && \
+ export PATH=$$SAGE_ROOT/build/bin:$$SAGE_ROOT/src/bin:$$PATH && \
./src/bin/sage-download-upstream
dist: build/make/Makefile Then (after #29316) users will be warned that they have to run |
comment:3
Although there is another issue: diff --git a/src/bin/sage-download-upstream b/src/bin/sage-download-upstream
index c5d9afe31e..226806ab7d 100755
--- a/src/bin/sage-download-upstream
+++ b/src/bin/sage-download-upstream
@@ -1,8 +1,8 @@
#!/usr/bin/env bash
-for pkg in $SAGE_ROOT/build/pkgs/*
+for pkg in `sage --package list :standard:`
do
- if [ -d $pkg ]; then
+ if [ -d $SAGE_ROOT/build/pkgs/$pkg ]; then
sage-spkg -d `basename $pkg`
fi
done |
comment:5
I could also imagine trying to use the results from |
comment:7
Should this be using the same logic as |
comment:8
Replying to @jhpalmieri:
That's my instinct. We probably don't need both |
Dependencies: #30846 |
Branch: u/mkoeppe/fix_make_download |
comment:12
The branch "fixes" I don't use this myself, so I don't know what is the best way to proceed regarding "standard" vs. "all" vs. "configured" packages. Perhaps they should be 3 different make targets. New commits:
|
Commit: |
Author: John Palmieri, Matthias Koeppe |
comment:13
In case that is relevant to the present ticket: our release manager
|
Changed keywords from none to download |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:17
No longer depends on #30846 |
Changed dependencies from #30846 to none |
comment:18
(pushed to wrong ticket) |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits: |
comment:20
Actually best to go through #30865, |
Changed author from John Palmieri, Matthias Koeppe to none |
Dependencies: #30865 |
Reviewer: Dima Pasechnik |
This is broken, as reported on
https://groups.google.com/d/msg/sage-devel/KA8tI5GsFX4/1KIV2iuIBwAJ
Depends on #30865
CC: @saliola @mkoeppe @orlitzky @slel @vbraun
Component: distribution
Keywords: download
Branch/Commit: u/mkoeppe/fix_make_download @
039fed7
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/29896
The text was updated successfully, but these errors were encountered: