Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more homebrew system package information, including packages without spkg-configure.m4 #30861

Closed
mkoeppe opened this issue Nov 3, 2020 · 38 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 3, 2020

Along the same lines as #30859 for Debian,
this is for several purposes:

(see also #29146)

(from #30371)

Related:

This ticket does not cover Homebrew packages available via taps.

Interested users can install GAP, Macaulay2 and Polymake as follows:

$ brew tap gap-system/gap
$ brew install gap

$ brew tap macaulay2/tap
$ brew install macaulay2

$ brew tap apaffenholz/polymake
$ brew install polymake

Depends on #29124

CC: @tobiasdiez @slel @dimpase @jhpalmieri

Component: build: configure

Keywords: homebrew, spkg-configure.m4, macos

Author: Samuel Lelièvre, Matthias Koeppe

Branch/Commit: c2b36c7

Reviewer: Matthias Koeppe, Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/30861

@mkoeppe mkoeppe added this to the sage-9.3 milestone Nov 3, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@slel
Copy link
Member

slel commented Nov 4, 2020

Changed keywords from none to homebrew, spkg-configure.m4

@slel

This comment has been minimized.

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Nov 4, 2020

Changed keywords from homebrew, spkg-configure.m4 to homebrew, spkg-configure.m4, macos

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 4, 2020

Dependencies: #30865

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 23, 2020

Changed dependencies from #30865 to #30865, #30951

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 23, 2020

Changed dependencies from #30865, #30951 to #30865, #30951, #30745

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 24, 2020

Changed dependencies from #30865, #30951, #30745 to #30865, #30951, #30745, #29124

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 24, 2020

comment:8

The preparations are done in #29124. Now the system packages can be added

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 10, 2021

Changed dependencies from #30865, #30951, #30745, #29124 to #29124

@mkoeppe

This comment has been minimized.

@slel
Copy link
Member

slel commented Mar 20, 2021

Author: Samuel Lelièvre

@slel
Copy link
Member

slel commented Mar 20, 2021

comment:10

Ready for review.


New commits:

dc64c6230861: Add Homebrew package info

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Mar 20, 2021

Commit: dc64c62

@slel
Copy link
Member

slel commented Mar 20, 2021

Branch: public/30861

@slel
Copy link
Member

slel commented Mar 20, 2021

comment:11

Also available from Macaulay2 taps: fflas-ffpack, frobby, gfan, givaro.

However they break building Sage, see

Also available from GAP tap: gap

@slel

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 20, 2021

comment:13

We don't really have a mechanism yet to ask users to use a tap - I would need that for polymake too - #31527

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Mar 20, 2021

comment:15

The homebrew-maximal test environment could install extra packages from taps anyway.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 20, 2021

comment:16

Replying to @slel:

The homebrew-maximal test environment could install extra packages from taps anyway.

Well, it's easy to implement in build/bin/sage-print-system-package-command - in order to give both advice for users and set up the -maximal environment. I think I'll implement this in the polymake ticket.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 20, 2021

comment:17

The mactex bottle is giving me an error when I do tox -e local-homebrew-macos-maximal -- config.status.

==> Downloading http://mirror.ctan.org/systems/mac/mactex/mactex-20200407.pkg
==> Downloading from https://ctan.math.illinois.edu/systems/mac/mactex/mactex-20200407.pkg
######################################################################## 100.0%
==> Installing dependencies: jpeg, libtiff, ghostscript
==> Downloading https://homebrew.bintray.com/bottles/jpeg-9d.catalina.bottle.tar.gz
Already downloaded: /Users/mkoeppe/s/sage/sage-rebasing/worktree-algebraic-2018-spring/.tox/local-homebrew-macos-maximal/Library/Caches/Homebrew/downloads/9ed6b08679bb12bb63055c727e5cdcb7f0813e6a89a66ee35a2b2b83d1c30ac9--jpeg-9d.catalina.bottle.tar.gz
==> Installing jpeg
Error: No such file or directory @ dir_chdir - /Users/mkoeppe/s/sage/sage-rebasing/worktree-algebraic-2018-spring/.tox/local-homebrew-macos-maximal/homebrew/Cellar

Let's remove build/pkgs/texlive/distros/homebrew.txt and revisit this in #31529.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 20, 2021

Changed commit from dc64c62 to 72d6b13

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 20, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

4eb1ba7build/pkgs/texlive/distros/homebrew.txt: Remove to avoid installation errors
72d6b13build/pkgs/singular/distros/homebrew.txt: Disable to avoid installation errors

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 21, 2021

comment:19

With these changes, it goes through and reports:


    notice: the following SPKGs did not find equivalent system packages:

        _recommended brial cddlib cliquer coxeter3 eclib ecm fflas_ffpack flintqs gf2x gfan giac givaro gp2c iml lcalc libbraiding libhomfly libsemigroups lrcalc m4ri m4rie palp pari pari_elldata pari_galdata pari_galpol pari_nftables pari_seadata pari_seadata_small perl_cpan_polymake_prereq perl_term_readline_gnu planarity rw symmetrica sympow tachyon zn_poly
        
checking for the package system in use... homebrew
configure:

    hint: installing the following system packages, if not
    already present, is recommended and may avoid having to
    build them (though some may have to be built anyway):

      $ brew install ffmpeg imagemagick texinfo cddlib
    

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 21, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

c2b36c7build/pkgs/cddlib/distros/homebrew.txt: Disable cddlib for now (waiting for #29413)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 21, 2021

Changed commit from 72d6b13 to c2b36c7

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 21, 2021

Reviewer: Matthias Koeppe

@slel
Copy link
Member

slel commented Mar 21, 2021

comment:22

Thanks!

@slel
Copy link
Member

slel commented Mar 21, 2021

Changed author from Samuel Lelièvre to Samuel Lelièvre, Matthias Koeppe

@slel
Copy link
Member

slel commented Mar 21, 2021

Changed reviewer from Matthias Koeppe to Matthias Koeppe, Samuel Lelièvre

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Apr 15, 2021
@vbraun
Copy link
Member

vbraun commented May 27, 2021

Changed branch from public/30861 to c2b36c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants