Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to givaro-4.2.0 fflas-ffpack-2.5.0 linbox-1.7.0 #32959

Closed
ClementPernet opened this issue Dec 2, 2021 · 51 comments · Fixed by #37938
Closed

Upgrade to givaro-4.2.0 fflas-ffpack-2.5.0 linbox-1.7.0 #32959

ClementPernet opened this issue Dec 2, 2021 · 51 comments · Fixed by #37938

Comments

@ClementPernet
Copy link
Contributor

New packages are available here (with the corresponding checksums):

givaro: https://github.com/linbox-team/givaro/releases/tag/v4.2.0

fflas-ffpack: https://github.com/linbox-team/fflas-ffpack/releases/tag/v2.5.0

linbox: https://github.com/linbox-team/linbox/releases/tag/v1.7.0

The new versions require "a C++ compiler supporting C++11 standard. More precisely g++ v5 or greater, clang++ v3.4 or greater".
So this ticket depends on dropping support for some systems, see #32074.

Depends on #33316

CC: @kiwifb @orlitzky

Component: packages: standard

Branch/Commit: u/cpernet/upgrade_to_givaro_4_2_0_fflas_ffpack_2_5_0_linbox_1_7_0 @ 4006e10

Issue created by migration from https://trac.sagemath.org/ticket/32959

@ClementPernet

This comment has been minimized.

@ClementPernet

This comment has been minimized.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 2, 2021

comment:3

I see numerous build errors in https://github.com/linbox-team/fflas-ffpack/runs/4383290866?check_suite_focus=true that will need fixing before we can do these updates

@ClementPernet
Copy link
Contributor Author

comment:5

Of course. I just created this ticket to start working on a its branch, which will help us fix the last issues before cutting the final releases.
Btw, I did not manage to access to the full artifact of the givaro install log givaro which caused the failures in these github action builds (only the tail of the givaro-log is displayed in the sage build log in your link). Is there any way to access it? (I could not find it in the whole log archive).

@ClementPernet
Copy link
Contributor Author

@ClementPernet

This comment has been minimized.

@ClementPernet
Copy link
Contributor Author

New commits:

55bd2faupdate to givaro-4.2.0rc0
be8b20dfflas-ffpack-2.5.0rc1
bd36004fflas-ffpack-2.5.0rc1 fingerprints

@ClementPernet
Copy link
Contributor Author

Commit: bd36004

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 3, 2021

comment:8

Replying to @ClementPernet:

I did not manage to access to the full artifact of the givaro install log givaro which caused the failures in these github action builds (only the tail of the givaro-log is displayed in the sage build log in your link). Is there any way to access it? (I could not find it in the whole log archive).

In each run, such as https://github.com/linbox-team/fflas-ffpack/runs/4383290866?check_suite_focus=true, there is a section "Print out logs for immediate inspection" in the output, which shows all logs of failing package builds in full.

When all jobs have completed, the summary page, such as https://github.com/linbox-team/fflas-ffpack/actions/runs/1526437644, gives access to the log artifacts.
For example, logs-commit-3e42b4a1aaa585bce832738d5a8885dcf7c4273e-tox-docker-ubuntu-xenial-standard (https://github.com/linbox-team/fflas-ffpack/suites/4521078418/artifacts/121757925) gives a zip file within which you will find logs/pkgs/givaro-git.log

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 3, 2021

comment:9

We have a bit of documentation on this at https://doc.sagemath.org/html/en/developer/portability_testing.html#automatic-parallel-tox-runs-on-github-actions; if you feel anything needs to be added, let me know

@ClementPernet
Copy link
Contributor Author

comment:10

Thanks a lot for the pointers.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 7, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

6eca64ffix with LinBox new API
5a968caLinBox new API for DenseMatrix
78308b7checksums

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 7, 2021

Changed commit from bd36004 to 78308b7

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 8, 2021

comment:13

The checksums.ini files should get upstream_url lines, see https://doc.sagemath.org/html/en/developer/packaging.html#upstream-urls

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 14, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

065177aupdate checksums and versions to latest released linbox, fflas-ffpack and givaro

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 14, 2021

Changed commit from 78308b7 to 065177a

@ClementPernet
Copy link
Contributor Author

comment:15

I just released the three libraries and updated this branch with the corresponding checksums, and added the upstream_url as requested.

I could check that the testsuite passes on 2 machines (broadwell and skylake-X both running Linux mint).

I only had to comment out local/include/factory/factory.h line 92 (#define IntegerDomain 1), because this define by Singular gets in the way of Givaro's Givaro::IntegerDomain. See https://groups.google.com/g/sage-devel/c/lC941Lab5ck

Dima suggested to pacth this file, but I am not sure to see where this should be done in sage install process. Any help would be most welcome.

@dimpase
Copy link
Member

dimpase commented Dec 14, 2021

comment:16

Does Singular/Singular@18bb792
do the job? Or they made an error there, it doesn't fix anything for you?

@dimpase
Copy link
Member

dimpase commented Dec 14, 2021

comment:17

Replying to @dimpase:

Does Singular/Singular@18bb792
do the job? Or they made an error there, it doesn't fix anything for you?

Note that the patched file is actually meant to be preprocessed by Singular's ./factory/bin/makeheader

@orlitzky
Copy link
Contributor

comment:18

Replying to @ClementPernet:

Dima suggested to pacth this file, but I am not sure to see where this should be done in sage install process. Any help would be most welcome.

I don't think there's such an easy solution. The straightforward one is to wait for a new singular release, and then upgrade singular and givaro in sage at the same time, after enough distributions have packaged them both.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 14, 2021

comment:19

I would suggest to work around this clash in Givaro.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 14, 2021

comment:20

The latest run of the integration testing workflow - https://github.com/linbox-team/fflas-ffpack/runs/4511137082?check_suite_focus=true - fails badly on all platforms

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@ClementPernet
Copy link
Contributor Author

comment:22

Replying to @mkoeppe:

The latest run of the integration testing workflow - https://github.com/linbox-team/fflas-ffpack/runs/4511137082?check_suite_focus=true - fails badly on all platforms

This run does not correspond to the released package and the failure there has been fixed in a more recent commit which is in the release.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 14, 2021

comment:23

You may want to cancel the runs that are no longer needed so that the current one gets a chance to run

@mkoeppe mkoeppe added this to the sage-9.7 milestone Feb 6, 2022
@ClementPernet
Copy link
Contributor Author

comment:42

Replying to @mkoeppe:

This looks like a good solution for now, but this will become an obstacle to modularization pretty soon.

Should I revert this commit, as the fixed Singular is now released ? I am not sure what's the best move to get thinks rolling. Just let me know.

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 7, 2022

comment:43

This would depend on

  • actually making the Singular update (update Singular to 4.3.1 #33160, which needs help)
  • tightening our version requirement in build/pkgs/singular/spkg-configure.m4

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 7, 2022

comment:44

By the way, I've marked this ticket for Sage 9.7 because of the increased compiler requirements (see #32074).

Also before we can merge this upgrade, Cygwin support needs to repaired (https://github.com/linbox-team/fflas-ffpack/runs/4658698318)

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 7, 2022

comment:45

Also, 32bit platforms seem broken

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 8, 2022

Dependencies: #33316

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 5, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 25, 2022

comment:48

@ClementPernet Is it planned to release new versions of the packages that include patches you may have received from distribution packaging?

@ClementPernet
Copy link
Contributor Author

comment:49

Yes, I'm finally getting back to it, and would like to cut a minor version in a near future (say september or october) fixing the various issues raised here and in other PRs.

@isuruf
Copy link
Member

isuruf commented Apr 27, 2023

@ClementPernet, any plans for a new minor version?

@mkoeppe mkoeppe removed this from the sage-10.0 milestone Apr 30, 2023
@mkoeppe mkoeppe added this to the sage-10.3 milestone Oct 23, 2023
@mkoeppe mkoeppe removed this from the sage-10.3 milestone Feb 29, 2024
vbraun pushed a commit to vbraun/sage that referenced this issue May 5, 2024
…-2.5.0

### 📚 Description

Draft PR taken from sagemath#35148. I rebased on top of 10.4 and added two more
patches taken from upstream

@ClementPernet

closes sagemath#32959
closes sagemath#35148

URL: sagemath#37938
Reported by: Volker Braun
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this issue May 9, 2024
…-2.5.0

### 📚 Description

Draft PR taken from sagemath#35148. I rebased on top of 10.4 and added two more
patches taken from upstream

@ClementPernet

closes sagemath#32959
closes sagemath#35148

URL: sagemath#37938
Reported by: Volker Braun
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this issue May 11, 2024
…-2.5.0

### 📚 Description

Draft PR taken from sagemath#35148. I rebased on top of 10.4 and added two more
patches taken from upstream

@ClementPernet

closes sagemath#32959
closes sagemath#35148

URL: sagemath#37938
Reported by: Volker Braun
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this issue May 11, 2024
…-2.5.0

    
### 📚 Description

Draft PR taken from sagemath#35148. I rebased on top of 10.4 and added two more
patches taken from upstream

@ClementPernet

closes sagemath#32959
closes sagemath#35148
    
URL: sagemath#37938
Reported by: Volker Braun
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this issue May 12, 2024
…-2.5.0

    
### 📚 Description

Draft PR taken from sagemath#35148. I rebased on top of 10.4 and added two more
patches taken from upstream

@ClementPernet

closes sagemath#32959
closes sagemath#35148
    
URL: sagemath#37938
Reported by: Volker Braun
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this issue May 12, 2024
…-2.5.0

    
### 📚 Description

Draft PR taken from sagemath#35148. I rebased on top of 10.4 and added two more
patches taken from upstream

@ClementPernet

closes sagemath#32959
closes sagemath#35148
    
URL: sagemath#37938
Reported by: Volker Braun
Reviewer(s):
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment