Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove imports from sage.libs.all #32999

Closed
mkoeppe opened this issue Dec 9, 2021 · 11 comments
Closed

Remove imports from sage.libs.all #32999

mkoeppe opened this issue Dec 9, 2021 · 11 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 9, 2021

Depends on #33007

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 89e99f5

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/32999

@mkoeppe mkoeppe added this to the sage-9.5 milestone Dec 9, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2021

New commits:

1bab7abgit grep -l 'libs[.]all import' | xargs sed -i.bak '/[Pp]ari/s/from sage.libs.all import/from sage.libs.pari.all import/'
46ad7a0git grep -l 'libs[.]all import' | xargs sed -i.bak '/[Gg]ap/s/from sage.libs.all import/from sage.libs.gap.libgap import/'

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2021

Commit: 46ad7a0

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2021

Author: Matthias Koeppe

@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 15, 2021

comment:4

Thanks!

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Jan 10, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 11, 2022

Changed commit from 46ad7a0 to 89e99f5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 11, 2022

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:

2d9a84egit grep -l 'misc.all import' | xargs sed -i.bak 's/misc.all import tmp_/misc.temporary_file import tmp_/'
5a8d76eRemove imports from sage.misc.all
97b4dfdgit grep -l 'misc.all import' | xargs sed -i.bak 's/misc.all import sage_eval/misc.sage_eval import sage_eval/'
e72dc8eRemove more imports from sage.misc.all
d114096git grep -l 'misc.all import' | xargs sed -i.bak 's/misc.all import cartesian_product_iterator/misc.mrange import cartesian_product_iterator/'
1ab9441Remove remaining imports from sage.misc.all
0e814dcMerge #32989
37789fdMerge tag '9.5.beta9' into t/33007/remove_imports_from_sage_interfaces_all
584d121src/sage/rings/polynomial/multi_polynomial_libsingular.pyx: Fix import
89e99f5Merge #33007

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 11, 2022

comment:7

Merged #33007 to fix merge conflict

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 11, 2022

Dependencies: #33007

@vbraun
Copy link
Member

vbraun commented Feb 13, 2022

Changed branch from u/mkoeppe/remove_imports_from_sage_libs_all to 89e99f5

@vbraun vbraun closed this as completed in 04a135d Feb 13, 2022
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants