-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cypari2 to 2.1.3 #33878
Comments
Dependencies: #33864 |
Branch: public/33878 |
Commit: |
comment:3
Is there any reason you are using snapshots from your fork of |
comment:5
Still getting
with this ticket |
comment:6
Sorry about that. I messed up with the tags. I'm rather confident the fix is working, it's just that the fix is not contained in the tag I created. |
comment:7
The new commit contains the recent changes. The test release contains basically the following:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:16
Regarding the ticket description: to make pari threadsafe, the only way I explored so far was to use a "thread pool executor", see sagemath/cypari2#116. Because of its stack management, pari needs some care when used within threads. |
This comment has been minimized.
This comment has been minimized.
comment:18
I don't remember the details about this, but there is also a separate related ticket: #28800 |
Author: Matthias Koeppe |
comment:21
Tests look OK, let's get this in |
comment:22
lgtm - tested with Pari 2.,15.1 |
Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/3448209182 to Dima Pasechnik |
comment:23
Thanks! |
Changed branch from public/33878 to |
This is needed for python 3.11 support (#33842) and to make cypari compatible with current pari version
https://groups.google.com/g/sage-devel/c/jqmr6bDjDrk/m/XE2GlB_GBgAJ
Necessary follow ups:
Depends on #33864
CC: @videlec @dimpase
Component: build
Author: Matthias Koeppe
Branch/Commit:
0ac9905
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/33878
The text was updated successfully, but these errors were encountered: