Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Cython 0.11.2 #6438

Closed
robertwb opened this issue Jun 28, 2009 · 10 comments
Closed

Upgrade to Cython 0.11.2 #6438

robertwb opened this issue Jun 28, 2009 · 10 comments

Comments

@robertwb
Copy link
Contributor

At the very least, native complex support will be valuable.

The spkg at http://sage.math.washington.edu/home/robertwb/cython/ built and passed all doctests a couple of versions back.

Component: packages: standard

Author: Robert Bradshaw

Reviewer: Minh Van Nguyen

Merged: Sage 4.1.1.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/6438

@mwhansen
Copy link
Contributor

comment:1

Here is a direct link: http://sage.math.washington.edu/home/robertwb/cython/cython-0.11.2.spkg

@robertwb
Copy link
Contributor Author

comment:2

We should update to the latest tip to fix the numpy issue.

@jasongrout
Copy link
Member

comment:3

Does your comment mean that we need a new spkg? Is this a "needs work" ticket now?

@jasongrout
Copy link
Member

comment:5

On the other hand, the spkg seems fine, except that the SPKG.txt file does not include a changelog of any sort. Shouldn't this be added?

@robertwb
Copy link
Contributor Author

comment:6

http://sage.math.washington.edu/home/robertwb/cython/cython-0.11.2.1.spkg

I don't see anything in SPKG.txt that needs changing--the changelog would be pretty boring if it was there ("Upgraded to version x.y.z" * 100).

@robertwb
Copy link
Contributor Author

comment:7

Attachment: 6438-cython.patch.gz

All tests pass with the above spkg and patch.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 24, 2009

comment:8

The SPKG at

http://sage.math.washington.edu/home/robertwb/cython/cython-0.11.2.1.spkg

doesn't contain a file called .hgignore like the current version in Sage 4.1. So when one executes the command

hg status

one sees a lot of source files. I've added a .hgignore file to the repository of that SPKG. The updated SPKG is up at

http://sage.math.washington.edu/home/mvngu/patch/cython-0.11.2.1.spkg

All doctests passed with the latter SPKG and 6438-cython.patch.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 24, 2009

Merged: Sage 4.1.1.alpha1

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 24, 2009

Reviewer: Minh Van Nguyen

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 24, 2009

Author: Robert Bradshaw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants