Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

g.add_edge((u,v), label=l) syntax unsupported for C graphs #6540

Closed
rlmill mannequin opened this issue Jul 16, 2009 · 5 comments
Closed

g.add_edge((u,v), label=l) syntax unsupported for C graphs #6540

rlmill mannequin opened this issue Jul 16, 2009 · 5 comments
Assignees
@rlmill
Labels
c: graph theory p: major / 3 t: bug
Milestone
sage-4.1.1

Comments

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jul 16, 2009

CC: @jasongrout

Component: graph theory

Author: Robert Miller

Reviewer: Jason Grout

Merged: sage-4.1.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/6540
@rlmill rlmill mannequin added this to the sage-4.1.1 milestone Jul 16, 2009
@rlmill rlmill mannequin added c: graph theory labels Jul 16, 2009
@rlmill rlmill mannequin self-assigned this Jul 16, 2009
@rlmill rlmill mannequin added the s: needs review label Jul 16, 2009
@jasongrout
Copy link
Member

comment:1

Attachment: trac_6540-edge_syntax.patch.gz

@jasongrout
Copy link
Member

comment:2

This looks good and passes tests in graph.py.

The function has a blanket except: statement, which should instead trap the specific error it is expecting. But that is not this issue.

As a side note, I think there are too many syntax choices for creating edges, which not only creates obscure corner cases and parsing code like this, but also leads to code that goes against the python philosophy that there should be one way to do things ("https://github.com/sagemath/sage-prod/files/10645549/trac_6540-edge_syntax.patch.gz"). I don't have time to do anything about it, so this is just a hollow complaint now :).

@jasongrout
Copy link
Member

Reviewer: Jason Grout

@jasongrout
Copy link
Member

Author: Robert Miller

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 19, 2009

Merged: sage-4.1.1.alpha0

@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Jul 19, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlmill rlmill

Labels
c: graph theory p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.1.1
Development

No branches or pull requests
1 participant
@jasongrout