-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing q-commuting Laurent polynomials. #35054
Implementing q-commuting Laurent polynomials. #35054
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35054 +/- ##
===========================================
- Coverage 88.62% 88.58% -0.04%
===========================================
Files 2148 2140 -8
Lines 398653 397474 -1179
===========================================
- Hits 353308 352115 -1193
- Misses 45345 45359 +14
... and 68 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
1943b89
to
ad3ccce
Compare
looking at the doc reveals a few latex issues |
Indeed. My last commit should have fixed it/them (since it was really the same issue by copy/paste...). |
522 files changed.. It seems our old workflow is no longer really good.. |
45fb245
to
6d47e5f
Compare
This time I even merged it into develop... The whole setup we seem to be running for the diff is likely borked unless we have a "perfect" history. I just did a rebase (which seems to be the new SOP, but we will often have to rewrite history...), which I know fixes it. Tests passed before except for one which was unrelated. |
Thank you, although I think you also need to approve the PR... |
Thank you. |
Not sure if approval is required now. I have seen Volker saying that "positive review" was the criterion. |
I am not sure either; this isn't clear in the workflow doc as I recall it. |
Documentation preview for this PR is ready! 🎉 |
q
-commuting polynomials were introduced in #34412. This implements the followup #34472 ofq
-commuting Laurent polynomials.