Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing q-commuting Laurent polynomials. #35054

Merged
merged 6 commits into from
Mar 19, 2023

Conversation

tscrim
Copy link
Collaborator

@tscrim tscrim commented Feb 10, 2023

q-commuting polynomials were introduced in #34412. This implements the followup #34472 of q-commuting Laurent polynomials.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Patch coverage: 97.40% and project coverage change: -0.04 ⚠️

Comparison is base (f449b14) 88.62% compared to head (6d47e5f) 88.58%.

❗ Current head 6d47e5f differs from pull request most recent head 592e8a7. Consider uploading reports for the commit 592e8a7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35054      +/-   ##
===========================================
- Coverage    88.62%   88.58%   -0.04%     
===========================================
  Files         2148     2140       -8     
  Lines       398653   397474    -1179     
===========================================
- Hits        353308   352115    -1193     
- Misses       45345    45359      +14     
Impacted Files Coverage Δ
src/sage/algebras/q_commuting_polynomials.py 97.14% <97.36%> (-0.42%) ⬇️
src/sage/algebras/catalog.py 100.00% <100.00%> (ø)

... and 68 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tscrim tscrim force-pushed the algebras/quantum_laurent_polys-34472 branch from 1943b89 to ad3ccce Compare February 17, 2023 04:23
@fchapoton
Copy link
Contributor

looking at the doc reveals a few latex issues

@tscrim
Copy link
Collaborator Author

tscrim commented Mar 11, 2023

Indeed. My last commit should have fixed it/them (since it was really the same issue by copy/paste...).

@fchapoton
Copy link
Contributor

522 files changed.. It seems our old workflow is no longer really good..

@tscrim tscrim force-pushed the algebras/quantum_laurent_polys-34472 branch from 45fb245 to 6d47e5f Compare March 12, 2023 07:27
@tscrim
Copy link
Collaborator Author

tscrim commented Mar 12, 2023

This time I even merged it into develop... The whole setup we seem to be running for the diff is likely borked unless we have a "perfect" history. I just did a rebase (which seems to be the new SOP, but we will often have to rewrite history...), which I know fixes it.

Tests passed before except for one which was unrelated.

@tscrim
Copy link
Collaborator Author

tscrim commented Mar 13, 2023

Thank you, although I think you also need to approve the PR...

@tscrim
Copy link
Collaborator Author

tscrim commented Mar 13, 2023

Thank you.

@fchapoton
Copy link
Contributor

Not sure if approval is required now. I have seen Volker saying that "positive review" was the criterion.

@tscrim
Copy link
Collaborator Author

tscrim commented Mar 13, 2023

I am not sure either; this isn't clear in the workflow doc as I recall it.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 592e8a7

@vbraun vbraun merged commit d91eb2e into sagemath:develop Mar 19, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 19, 2023
@tscrim tscrim deleted the algebras/quantum_laurent_polys-34472 branch April 28, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants