fixed warning while calling OEISSequence.is_dead() function #36811

amanmoon · 2023-12-04T00:10:55Z

Fixes #36795
fixed warning in OEISSequence.is_dead() function in OEISSequence

added a parameter warn=True in _field function
and changed self.is_dead(warn_only=True) to self.is_dead(warn_only=warn) inside the _field function,
changed the self._field('K') to self._field('K', warn=False)
so the warning is not triggered

mantepse · 2023-12-10T19:30:21Z

With this PR, in a fresh session,

sage: oeis(17).keywords()
('dead',)
sage: oeis(17)
A000017: Erroneous version of A032522.

so we don't get any warning at all if we first ask for the keywords. I think that's OK, so if noone objects, this can go in.

One thing I just noticed - the documentation of is_dead reads:

        A warn_only test is triggered as soon as some information on the
        sequence is queried::

I think it would be an improvement to write

        A warning is triggered if any field of a dead sequence is accessed,
        unless :meth:`is_dead` is called before::

…changes

…oeis_changes

mantepse · 2023-12-13T08:15:01Z

Unfortunately, testing with

sage -t --optional=sage,internet src/sage/databases/oeis.py

reveals a new failure, which is real and should be fixed:

File "src/sage/databases/oeis.py", line 2016, in sage.databases.oeis.OEISSequence.test_compile_sage_code
Failed example:
    s.test_compile_sage_code()            # optional -- internet
Expected:
    doctest:warning
    ...
    RuntimeWarning: This sequence is dead: ...
    True
Got:
    True

I think one can fix this by adding an additional call self.is_dead(warn_only=True).

There are other serious failures, as noted by @seblabbe, https://groups.google.com/g/sage-release/c/ow2oou9Q2dk/m/WCRtC3AsAQAJ, but these should be fixed in a separate ticket.

dimpase · 2023-12-13T09:17:42Z

@mantepse - please try pressing "Approve and run" button

dimpase · 2023-12-13T10:06:51Z

I see the following (the button is 2/3rd down from the top)

dimpase · 2023-12-13T10:30:51Z

@mantepse - I don't know what's going on here. I think every member of https://github.com/orgs/sagemath/teams/triage
has access to this button.
And I see on my admin pages that

sagemath/sage
@mantepse mantepse has triage access over this repository

What browser/OS are you on? Do you use 2FA?

dimpase · 2023-12-13T10:32:06Z

anyhow, someone has just allowed a CI run - @mantepse - was it you?

dimpase · 2023-12-13T10:57:59Z

@mantepse - could you please log out and log in again?

Do you have 2FA set up for GitHub?

dimpase · 2023-12-13T11:36:09Z

Can I have a look at the bottom part of #36830 - between the last comment and the bottom ? (Either here or by email).

Firefox makes it easy to take screenshots of its pages (right click on the whitespace in the page, etc).

dimpase · 2023-12-13T12:16:10Z

@mantepse - I'll remove you from triage, and send you an invite. Maybe this will clean this up...

dimpase · 2023-12-13T12:19:50Z

@mantepse - I'll remove you from triage, and send you an invite. Maybe this will clean this up...

OK, I did this, and you got re-added to Triage. Has it helped?

dimpase · 2023-12-13T12:25:32Z

@mantepse - another thing, to exclude browser issues. Do you have another machine you can try this on?

Do you use gh https://cli.github.com/ ? If so, you'd have ability to trigger runs etc.

amanmoon · 2023-12-13T16:47:35Z

I added a warn=True in keywords method, this will ensure only oeis(17).is_dead() will return True without a warning.
This also solves the problem of oeis(17).keywords() and s.test_compile_sage_code() not returning a warning.

mantepse · 2023-12-14T10:28:27Z

I added a warn=True in keywords method, this will ensure only oeis(17).is_dead() will return True without a warning. This also solves the problem of oeis(17).keywords() and s.test_compile_sage_code() not returning a warning.

I'm sorry, but something went wrong here: I now get the warning no matter what I do:

sage: s = oeis(17)
sage: s.is_dead(warn_only=False)
/home/martin/sage/src/sage/databases/oeis.py:1153: RuntimeWarning: This sequence is dead: "A000017: Erroneous version of A032522."
  warn('This sequence is dead: "{}: {}"'.format(self.id(), self.name()), RuntimeWarning)
True

I think that it almost worked before the last commit, wouldn't it be sufficient to do the following? Or do you see other problems with this approach?

diff --git a/src/sage/databases/oeis.py b/src/sage/databases/oeis.py
index 867c66a757..2b8998f419 100644
--- a/src/sage/databases/oeis.py
+++ b/src/sage/databases/oeis.py
@@ -2020,6 +2020,7 @@ class OEISSequence(SageObject, UniqueRepresentation):
             True
         """
         if self.is_dead():
+            self.is_dead(warn_only=True)
             return True
         filt = self.programs(language='sage')
         if filt:

amanmoon · 2023-12-14T11:35:07Z

I thought the above changes will also solve the problem of oeis(17).keywords() not returning a warning.

mantepse · 2023-12-15T09:13:10Z

src/sage/databases/oeis.py

@@ -2019,7 +2019,7 @@ def test_compile_sage_code(self):
            RuntimeWarning: This sequence is dead: ...
            True
        """
-        if self.is_dead():
+        if self.is_dead(warn_only=True):


This does not look right: self.is_dead(warn_only=True) will always return None. The bug does not surface, because A000017 does not have sage code.

amanmoon · 2023-12-19T01:38:37Z

Whenever is_dead() method is called it loops from
is_dead() [where warn_only is initially false] => keywords() => _field() => is_dead() [warn_only becomes True and return warning if 'dead' is returned in keywords() method]

I added a third argument in is_dead() so whenever it loops from
is_dead() [where warn_only is initially false] => keywords() => _field() => is_dead() [warn_only remains False cause of the third argument]

mantepse · 2023-12-19T10:00:50Z

Did you see #36811 (comment) ?

amanmoon · 2023-12-19T14:01:12Z

Yes, I did but it does not solve the problem of oeis(17).keywords() not returning a warning.
If it is fine for oeis(17).keywords() to not return a warning then i can revert the changes and add self.is_dead(warn_only=True).

mantepse · 2023-12-19T14:28:34Z

Yes, I did but it does not solve the problem of oeis(17).keywords() not returning a warning. If it is fine for oeis(17).keywords() to not return a warning then i can revert the changes and add self.is_dead(warn_only=True).

I think it is ok if - in a fresh session,

sage: oeis(17).keywords()

warns, but - in a fresh session

sage: oeis(17).is_dead()
True
sage: oeis(17).keywords()

does not warn.

github-actions · 2023-12-19T15:56:02Z

Documentation preview for this PR (built with commit 8f9af0b; changes) is ready! 🎉

mantepse

Looks good, thank you so much!

If you have energy, it would be great if you could open an issue for the other issues, mentioned in #36811 (comment)!

If I did not overlook anything, the main issue is a weird change to the %I field, which seems to contain a date now.

…function Fixes sagemath#36795 fixed warning in OEISSequence.is_dead() function in OEISSequence added a parameter warn=True in _field function and changed self.is_dead(warn_only=True) to self.is_dead(warn_only=warn) inside the _field function, changed the self._field('K') to self._field('K', warn=False) so the warning is not triggered URL: sagemath#36811 Reported by: Aman Moon Reviewer(s): Martin Rubey

amanmoon and others added 2 commits December 4, 2023 05:36

fixed warning while calling OEISSequence.is_dead() function

966a6cb

Merge branch 'develop' into oeis_changes

c118632

amanmoon added 3 commits December 12, 2023 06:42

changed the documentation of function is_dead

9215e8d

Merge branch 'develop' of https://github.com/amanmoon/sage into oeis_…

e50dc97

…changes

Merge branch 'oeis_changes' of https://github.com/amanmoon/sage into …

87f7a32

…oeis_changes

mantepse added the s: needs review label Dec 12, 2023

mantepse self-requested a review December 12, 2023 16:50

This comment was marked as off-topic.

Sign in to view

added a warn=True argument in keywords method

21a2f38

This comment was marked as off-topic.

Sign in to view

mantepse reviewed Dec 15, 2023

View reviewed changes

reverted changes and added self.is_dead(warn_only=True)

2b8b0f3

amanmoon force-pushed the oeis_changes branch from 56ea7df to 2b8b0f3 Compare December 19, 2023 15:21

Merge branch 'develop' into oeis_changes

8f9af0b

mantepse approved these changes Dec 24, 2023

View reviewed changes

mantepse added s: positive review and removed s: needs review labels Dec 24, 2023

vbraun merged commit 003c1d9 into sagemath:develop Dec 26, 2023
19 of 20 checks passed

github-actions bot removed the s: positive review label Dec 26, 2023

mkoeppe added this to the sage-10.3 milestone Dec 26, 2023

amanmoon deleted the oeis_changes branch December 26, 2023 17:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixed warning while calling OEISSequence.is_dead() function #36811

fixed warning while calling OEISSequence.is_dead() function #36811

amanmoon commented Dec 4, 2023 •

edited

mantepse commented Dec 10, 2023

mantepse commented Dec 13, 2023

dimpase commented Dec 13, 2023

This comment was marked as off-topic.

dimpase commented Dec 13, 2023

This comment was marked as off-topic.

dimpase commented Dec 13, 2023

dimpase commented Dec 13, 2023

This comment was marked as off-topic.

dimpase commented Dec 13, 2023

This comment was marked as off-topic.

dimpase commented Dec 13, 2023

dimpase commented Dec 13, 2023

dimpase commented Dec 13, 2023

dimpase commented Dec 13, 2023

This comment was marked as off-topic.

amanmoon commented Dec 13, 2023

This comment was marked as off-topic.

mantepse commented Dec 14, 2023

amanmoon commented Dec 14, 2023 •

edited

mantepse Dec 15, 2023

amanmoon commented Dec 19, 2023

mantepse commented Dec 19, 2023

amanmoon commented Dec 19, 2023

mantepse commented Dec 19, 2023

github-actions bot commented Dec 19, 2023

mantepse left a comment •

edited

fixed warning while calling OEISSequence.is_dead() function #36811

fixed warning while calling OEISSequence.is_dead() function #36811

Conversation

amanmoon commented Dec 4, 2023 • edited

mantepse commented Dec 10, 2023

mantepse commented Dec 13, 2023

dimpase commented Dec 13, 2023

This comment was marked as off-topic.

dimpase commented Dec 13, 2023

This comment was marked as off-topic.

dimpase commented Dec 13, 2023

dimpase commented Dec 13, 2023

This comment was marked as off-topic.

dimpase commented Dec 13, 2023

This comment was marked as off-topic.

dimpase commented Dec 13, 2023

dimpase commented Dec 13, 2023

dimpase commented Dec 13, 2023

dimpase commented Dec 13, 2023

This comment was marked as off-topic.

amanmoon commented Dec 13, 2023

This comment was marked as off-topic.

mantepse commented Dec 14, 2023

amanmoon commented Dec 14, 2023 • edited

mantepse Dec 15, 2023

Choose a reason for hiding this comment

amanmoon commented Dec 19, 2023

mantepse commented Dec 19, 2023

amanmoon commented Dec 19, 2023

mantepse commented Dec 19, 2023

github-actions bot commented Dec 19, 2023

mantepse left a comment • edited

Choose a reason for hiding this comment

amanmoon commented Dec 4, 2023 •

edited

amanmoon commented Dec 14, 2023 •

edited

mantepse left a comment •

edited