Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give more precise answer on symbolic power of a matrix #36845

Merged
merged 10 commits into from
Dec 26, 2023

Commits on Dec 17, 2023

  1. Changed _matrix_power_symbolic function to condier mk=0 case

    This fixes sagemath#36838. Here, I have added a condition to check whether
    mk=0 or not. Because whenever mk=0 we should give mk^(n-i) (i.e. 0^(n-i))
    instead of only 0 considering (n-i) can be equal to zero and in this
    case 0^(n-i) will be more accurate than only 0.
    RuchitJagodara authored and dimpase committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    afa6a7c View commit details
    Browse the repository at this point in the history
  2. Changed the _matrix_power_symbolic function to handle all the cases

    This change handles all the errors which were occuring in previous
    commit and this commit handles the case of mx=0 very effectively.
    RuchitJagodara authored and dimpase committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    dc79089 View commit details
    Browse the repository at this point in the history
  3. Created tests covering the changes

    Created tests covering the changes and checking whether the
    trac:`36838` is fixed or not.
    RuchitJagodara authored and dimpase committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    7139bb8 View commit details
    Browse the repository at this point in the history
  4. Give more precise answer by using kroncker_delta function

    Instead of returning 0^(n-i), it would be more precise if
    we reutrn value of  kroncker_delta function, it will be helpful when
    we try to evaluate the final matrix using the value of n.
    RuchitJagodara authored and dimpase committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    42454c0 View commit details
    Browse the repository at this point in the history
  5. Rewriting tests for the PR

    Changed the final answer given by test of this PR.
    RuchitJagodara authored and dimpase committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    96442fb View commit details
    Browse the repository at this point in the history
  6. Correct answers of the doctest for _matrix_power_symbolic function

    Changed the answer of doctest  according to new changes.
    RuchitJagodara authored and dimpase committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    d40d348 View commit details
    Browse the repository at this point in the history
  7. Corrected the doctest

    Corrected the doctest and improved some code styles, which were not
    correct according to guidelines for python coding for sage.
    RuchitJagodara authored and dimpase committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    935a420 View commit details
    Browse the repository at this point in the history
  8. Modified the doctest and changed the comment

    Updated the old doctests which were failing before and updated the comment
    to make it more readable.
    RuchitJagodara authored and dimpase committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    7955a51 View commit details
    Browse the repository at this point in the history
  9. Corrected lint errors

    RuchitJagodara authored Dec 17, 2023
    Configuration menu
    Copy the full SHA
    ed4e712 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Configuration menu
    Copy the full SHA
    f95793b View commit details
    Browse the repository at this point in the history