-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give more precise answer on symbolic power of a matrix #36845
Give more precise answer on symbolic power of a matrix #36845
Commits on Dec 17, 2023
-
Changed _matrix_power_symbolic function to condier mk=0 case
This fixes sagemath#36838. Here, I have added a condition to check whether mk=0 or not. Because whenever mk=0 we should give mk^(n-i) (i.e. 0^(n-i)) instead of only 0 considering (n-i) can be equal to zero and in this case 0^(n-i) will be more accurate than only 0.
Configuration menu - View commit details
-
Copy full SHA for afa6a7c - Browse repository at this point
Copy the full SHA afa6a7cView commit details -
Changed the _matrix_power_symbolic function to handle all the cases
This change handles all the errors which were occuring in previous commit and this commit handles the case of mx=0 very effectively.
Configuration menu - View commit details
-
Copy full SHA for dc79089 - Browse repository at this point
Copy the full SHA dc79089View commit details -
Created tests covering the changes
Created tests covering the changes and checking whether the trac:`36838` is fixed or not.
Configuration menu - View commit details
-
Copy full SHA for 7139bb8 - Browse repository at this point
Copy the full SHA 7139bb8View commit details -
Give more precise answer by using kroncker_delta function
Instead of returning 0^(n-i), it would be more precise if we reutrn value of kroncker_delta function, it will be helpful when we try to evaluate the final matrix using the value of n.
Configuration menu - View commit details
-
Copy full SHA for 42454c0 - Browse repository at this point
Copy the full SHA 42454c0View commit details -
Changed the final answer given by test of this PR.
Configuration menu - View commit details
-
Copy full SHA for 96442fb - Browse repository at this point
Copy the full SHA 96442fbView commit details -
Correct answers of the doctest for _matrix_power_symbolic function
Changed the answer of doctest according to new changes.
Configuration menu - View commit details
-
Copy full SHA for d40d348 - Browse repository at this point
Copy the full SHA d40d348View commit details -
Corrected the doctest and improved some code styles, which were not correct according to guidelines for python coding for sage.
Configuration menu - View commit details
-
Copy full SHA for 935a420 - Browse repository at this point
Copy the full SHA 935a420View commit details -
Modified the doctest and changed the comment
Updated the old doctests which were failing before and updated the comment to make it more readable.
Configuration menu - View commit details
-
Copy full SHA for 7955a51 - Browse repository at this point
Copy the full SHA 7955a51View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed4e712 - Browse repository at this point
Copy the full SHA ed4e712View commit details
Commits on Dec 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f95793b - Browse repository at this point
Copy the full SHA f95793bView commit details