Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/sage/interfaces/{gap,kenzo,scilab}: fix doctests warnings #36896

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

dcoudert
Copy link
Contributor

Fix warnings like

File "src/sage/interfaces/gap.py", line 1509, in sage.interfaces.gap.gap_reset_workspace
Warning: Variable 'gap' referenced here was set only in doctest marked '# long time'
    P = [Process(target=gap, args=("14242",)) for i in range(4)]

File "src/sage/interfaces/kenzo.py", line 134, in sage.interfaces.kenzo.Sphere
Warning: Consider using a block-scoped tag by inserting the line 'sage: # optional - kenzo' just before this line to avoid repeating the tag 4 times
    from sage.interfaces.kenzo import Sphere # optional - kenzo

File "src/sage/interfaces/scilab.py", line 252, in sage.interfaces.scilab.Scilab.set_seed
Warning: Consider using a block-scoped tag by inserting the line 'sage: # optional - scilab' just before this line to avoid repeating the tag 4 times
    from sage.interfaces.scilab import Scilab # optional - scilab

We also use more block scope tags.

However, we let one warning in src/sage/interfaces/gp.py. This is a doctest with # 32-bit and # 64-bit tags.

File "src/sage/interfaces/gp.py", line 799, in sage.interfaces.gp.Gp.new_with_bits_prec
Warning: Variable 'pi_def' referenced here was set only in doctest marked '# needs sage.libs.pari sage.symbolic'
    pi_def.precision()

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit 78ac95b; changes) is ready! 🎉

Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkoeppe
Copy link
Member

mkoeppe commented Dec 16, 2023

we let one warning in src/sage/interfaces/gp.py. This is a doctest with # 32-bit and # 64-bit tags.

Yes, that's #36099

@dcoudert
Copy link
Contributor Author

Thank you.

@vbraun vbraun merged commit 220208d into sagemath:develop Dec 19, 2023
22 of 23 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants