configure.ac: Remove tests for outdated platforms
#36915
Conversation
mkoeppe
force-pushed
the
configure_ac_cleaning
branch
from
c682e30
to
19bbf47
Compare
|
What is an outdated platform? If a platform does not run an OS in the list of our release tour, is that outdated? |
|
Yes. Basically everything except for Linux and macOS. |
|
... also removed here:
|
|
Otherwise lgtm. |
| may not work. If you would like to help port Sage to $host, | ||
| please join the sage-devel discussion list - see | ||
| http://groups.google.com/group/sage-devel | ||
| The Sage community would also appreciate any patches you submit]]);; |
There was a problem hiding this comment.
I'd have left these lines 214/8 in. It doesn't harm.
There was a problem hiding this comment.
Do you understand that it is for example inviting people who try to build it on Cygwin to help us port it to Cygwin?
There was a problem hiding this comment.
In 2024, I don't think anyone in their right mind would try porting anything to Cygwin
There was a problem hiding this comment.
See, that's why I'm removing this line here. It's a milder solution than including the warning "If you dare to even mention your unsupported platform, a certain senior developer will unleash uncontrolled abuse on you."
There was a problem hiding this comment.
Are you going to remove all the "you welcome to contribute" everywhere in the docs too?
There was a problem hiding this comment.
Your favourite, and supported, platform, macOS, is a pile of merde, pardon my French.
Just by the way.
|
Would you rebase to |
mkoeppe
force-pushed
the
configure_ac_cleaning
branch
from
e142252
to
9c289a4
Compare
|
Rebased |
|
Thank you! |
|
I'm getting (but only after a |
|
Which system |
|
Fedora 39, kernel 6.6.11-200.fc39.x86_64, Ryzen 7 5800X Its pretty clear that its just a case of numerical noise, how about upping the tolerance? |
|
config.log please? |
|
I can also open a subset PR to bisect this if that's easier |
|
config.log.36915.before.txt The diff contains |
|
OK, thanks. I'll investigate. |
|
Apparently caused by 9ea8982 |
|
Doing this: diff --git a/configure.ac b/configure.ac
index a24562ea1a7..65937a73cf2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -344,12 +344,6 @@ AX_PROG_PERL_VERSION([5.8.0],[],[
# Check C/C++/Fortran compilers
###############################################################################
-# Save compiler flags as configured by the user.
-# We have to redo this, because otherwise `AC_PROG_CC` will just overwrite them.
-AC_SUBST(CFLAGS, "$CFLAGS")
-AC_SUBST(CXXFLAGS, "$CXXFLAGS")
-AC_SUBST(FCFLAGS, "$FCFLAGS")
-AC_SUBST(F77FLAGS, "$F77FLAGS")
AC_ARG_VAR(CFLAGS, C compiler flags)
AC_ARG_VAR(CXXFLAGS, C compiler flags)
AC_ARG_VAR(FCFLAGS, Fortran compiler flags)repairs the CFLAGS, but this is part of the "march=native" stuff, which I don't want to touch right now. So I'll just drop commit 9ea8982 here. |
…in texlive/spkg-configure.m4)
…platforms; do not invite users to port to random unsupported platforms
…es for prehistoric OS X versions
…re.ac -w --date=format:%Y | sort -k2'
mkoeppe
force-pushed
the
configure_ac_cleaning
branch
from
c773784
to
e0548a0
Compare
|
Documentation preview for this PR (built with commit e0548a0; changes) is ready! 🎉 |
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> Likewise for some configuration tests in some `spkg-configure.m4` and `spkg-install` scripts. Cygwin, AIX, Solaris, ancient OS X, etc. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36915 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik, Kwankyu Lee, Matthias Köppe
Likewise for some configuration tests in some
spkg-configure.m4andspkg-installscripts.Cygwin, AIX, Solaris, ancient OS X, etc.
📝 Checklist
⌛ Dependencies