Adding methods .x() and .y() for EllipticCurvePoint #37092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 8923a6a; changes) is ready! 🎉 |
yyyyx4
reviewed
Jan 21, 2024
| ... | ||
| ZeroDivisionError: rational division by zero | ||
| """ | ||
| if self[2] == 1: |
There was a problem hiding this comment.
The call a.is_one() is quite a lot faster than the test a == 1: The reason is that the latter spends time on converting the Python integer 1 into the parent of a.
There was a problem hiding this comment.
Fixed. I also modified the method .xy() both to keep them equal and for the same speed reason
yyyyx4
approved these changes
Jan 22, 2024
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 24, 2024
Added the more natural notation P.x() and P.y() to access respectively the x and y coordinates of an EllipticCurvePoint. The behaviour mimics P.xy() and aims to replace P.xy()[0] and P.xy()[1]. Multiple instances of P.xy()[0] and P.xy()[1] are also replaced in related modules. #sd123 Done with @gioella URL: sagemath#37092 Reported by: Riccardo Invernizzi Reviewer(s): Lorenz Panny, Riccardo Invernizzi
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 27, 2024
Added the more natural notation P.x() and P.y() to access respectively the x and y coordinates of an EllipticCurvePoint. The behaviour mimics P.xy() and aims to replace P.xy()[0] and P.xy()[1]. Multiple instances of P.xy()[0] and P.xy()[1] are also replaced in related modules. #sd123 Done with @gioella URL: sagemath#37092 Reported by: Riccardo Invernizzi Reviewer(s): Lorenz Panny, Riccardo Invernizzi
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 29, 2024
Added the more natural notation P.x() and P.y() to access respectively the x and y coordinates of an EllipticCurvePoint. The behaviour mimics P.xy() and aims to replace P.xy()[0] and P.xy()[1]. Multiple instances of P.xy()[0] and P.xy()[1] are also replaced in related modules. #sd123 Done with @gioella URL: sagemath#37092 Reported by: Riccardo Invernizzi Reviewer(s): Lorenz Panny, Riccardo Invernizzi
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 30, 2024
Added the more natural notation P.x() and P.y() to access respectively the x and y coordinates of an EllipticCurvePoint. The behaviour mimics P.xy() and aims to replace P.xy()[0] and P.xy()[1]. Multiple instances of P.xy()[0] and P.xy()[1] are also replaced in related modules. #sd123 Done with @gioella URL: sagemath#37092 Reported by: Riccardo Invernizzi Reviewer(s): Lorenz Panny, Riccardo Invernizzi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the more natural notation P.x() and P.y() to access respectively the x and y coordinates of an EllipticCurvePoint. The behaviour mimics P.xy() and aims to replace P.xy()[0] and P.xy()[1].
Multiple instances of P.xy()[0] and P.xy()[1] are also replaced in related modules.
#sd123
Done with @gioella