Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Parent in quadratic number fields #37165

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

fchapoton
Copy link
Contributor

as another little step towards getting rid of ParentWithBase

馃摑 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Copy link

Documentation preview for this PR (built with commit c703c62; changes) is ready! 馃帀

Copy link
Member

@mezzarobba mezzarobba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 30, 2024
    
as another little step towards getting rid of `ParentWithBase`

### 馃摑 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37165
Reported by: Fr茅d茅ric Chapoton
Reviewer(s): Marc Mezzarobba
@vbraun vbraun merged commit bb09b47 into sagemath:develop Feb 2, 2024
21 of 22 checks passed
@fchapoton fchapoton deleted the parent_for_quadratic_fields branch February 3, 2024 08:22
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants