use parent in quaternions #37299
Merged
use parent in quaternions #37299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
requested changes
Feb 12, 2024
| """ | ||
| return self.base_ring().characteristic() | ||
|
|
||
| def has_standard_involution(self): |
There was a problem hiding this comment.
Should we move this method to AlgebrasWithBasis instead? Then we can assume it has a basis() method.
There was a problem hiding this comment.
not here and now. This would require making quaternion algebras to be WithBasis (they are not) and this takes some work
|
Documentation preview for this PR (built with commit d7c4495; changes) is ready! 🎉 |
tscrim
approved these changes
Feb 13, 2024
|
LGTM. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2024
replace the auld-style class by `Parent` and categories for quaternion
algebras.
### 📝 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
URL: sagemath#37299
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 19, 2024
replace the auld-style class by `Parent` and categories for quaternion
algebras.
### 📝 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
URL: sagemath#37299
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace the auld-style class by
Parentand categories for quaternion algebras.📝 Checklist