-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use parent in quaternions #37299
use parent in quaternions #37299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some little things. Otherwise LGTM.
""" | ||
return self.base_ring().characteristic() | ||
|
||
def has_standard_involution(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move this method to AlgebrasWithBasis
instead? Then we can assume it has a basis()
method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not here and now. This would require making quaternion algebras to be WithBasis
(they are not) and this takes some work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, no problem.
Documentation preview for this PR (built with commit d7c4495; changes) is ready! 🎉 |
LGTM. |
replace the auld-style class by `Parent` and categories for quaternion algebras. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. URL: sagemath#37299 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
replace the auld-style class by `Parent` and categories for quaternion algebras. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. URL: sagemath#37299 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
replace the auld-style class by
Parent
and categories for quaternion algebras.📝 Checklist