Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docstrings in groups #37790

Merged
merged 5 commits into from
Apr 27, 2024
Merged

Improve docstrings in groups #37790

merged 5 commits into from
Apr 27, 2024

Conversation

gmou3
Copy link
Contributor

@gmou3 gmou3 commented Apr 11, 2024

I parsed the groups module like a robot and I edited the docstrings. (e.g. 1-line outputs, self to self)

⌛ Dependencies

Depends on #37789.

mkoeppe
mkoeppe reviewed Apr 12, 2024
View reviewed changes
src/sage/groups/generic.py Outdated Show resolved Hide resolved
mkoeppe
mkoeppe reviewed Apr 12, 2024
View reviewed changes
src/sage/groups/generic.py Outdated Show resolved Hide resolved
mkoeppe
mkoeppe reviewed Apr 12, 2024
View reviewed changes
src/sage/groups/group.pyx Outdated Show resolved Hide resolved
@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 12, 2024

Thanks for this careful cleanup!

gmou3 and others added 2 commits April 12, 2024 09:33
@gmou3 @mkoeppe
Apply suggestions from code review
9a95ad4 
Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
@gmou3
Revert abelian_gps/all.py and move a dash
19f157e
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 19f157e; changes) is ready! 🎉

mkoeppe
mkoeppe approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 0a7b251 into sagemath:develop Apr 27, 2024
13 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Apr 27, 2024
@gmou3 gmou3 deleted the groups_docstrings branch April 27, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
c: documentation c: group theory
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@gmou3 @mkoeppe @vbraun @fchapoton