Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form inline #162

Closed
jorgjanke opened this Issue Mar 7, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@jorgjanke
Copy link

jorgjanke commented Mar 7, 2016

form inline is now with mq-large-min, which is far too big -- also a breaking change!
Inline forms are usually just a field or two and a button, intended to fit on a single line.

mq-small-min would be more appropriate (I think).

Instead of hardcoding, I suggest to allow the user/designer to choose when it should go back to "stacked" (or actually better horizontal)

.slds-form--inline__always (i.e. pre 1.0 behavior)
.slds-form--inline__small
.slds-form--inline__large

matt-lukens pushed a commit to ncino/design-system that referenced this issue Mar 7, 2016

Merge pull request salesforce-ux#162 from salesforce-ux/feature/lint-…
…LeadingZero

Throw warnings when a zero does not precede a decimal number between 0 and 1

@brandonferrua brandonferrua added the bug label Mar 7, 2016

@brandonferrua brandonferrua self-assigned this Mar 7, 2016

@brandonferrua

This comment has been minimized.

Copy link
Contributor

brandonferrua commented Mar 9, 2016

Thanks for reporting this and apologies for the regression. We will be changing the breakpoint to small for now and take into consideration the opt in classes for a future release.

kaelig pushed a commit that referenced this issue Apr 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.