Unexpected output when working with ARNs that have a path in them #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…alesforce#242) * Changes to IAM Definition - so far untested and have not adjusted query methods * Speed improvements by changing the IAM definition * Make pylint happy * Refresh docs and fix tests * Version bump
…gration (salesforce#247) * renaming test.yml to ci.yaml
* fix NoneType error in get_actions_for_service
…rce#249) * fix exception handling in get_action_for_service * update readme
salesforce#250) * fix exception handling in get_action_for_service * adding unit tests * rename unit test file
update awsdocs.py for new AWS formatting changes
…ndition Keys. Future-proofed some unit tests to prevent them from breaking after AWS updates their docs. (salesforce#258) Related to salesforce#256
…aracters and improve the unit tests for minimization (salesforce#259) * Ensured minimization won't break if resource path contains special characters; improve the unit tests for minimization * Added more test cases for the minimizing functions
…and (salesforce#261) * add resource type flag in query action-table * add unit test * updating doc for resource-type param
…ta source; added --fmt terraform which outputs policy as a json string embedded in json; allowed --minimize to accept a negative value to denote None (salesforce#263)
Fix logging
Migrate Terraform module to salesforce org; Clean up .gitignore
…ons - Fixes salesforce#278 (salesforce#279) * Clean up variables file and readme in Terraform modules * Fixes salesforce#278 - improved IAM policy output format, added exclude_actions and skip_resource_constraints fields
|
Thanks for the contribution! Before we can merge this, we need @actions-user to sign the Salesforce.com Contributor License Agreement. |
saikirankv
added
enhancement
kmcquade
reviewed
Nov 18, 2020
test/util/test_arns.py
Outdated
|
|
||
| self.assertTrue(does_arn_match(s3_object_without_path, s3_object_raw_arn)) | ||
| self.assertTrue(does_arn_match(s3_object_with_path, s3_object_raw_arn)) | ||
| # self.assertFalse(does_arn_match(s3_object_with_path, s3_bucket_raw_arn)) |
There was a problem hiding this comment.
Why are these commented out?
kmcquade
reviewed
Nov 18, 2020
test/util/test_arns.py
Outdated
| self.assertTrue(does_arn_match(ecr_arn_with_path, ecr_raw_arn)) | ||
| self.assertTrue(does_arn_match(ecr_arn_without_path, ecr_raw_arn)) | ||
|
|
||
| {"arn:aws:dynamodb:us-east-1:123456789123:table/mytable/backup/mybackup", "arn:${Partition}:dynamodb:${Region}:${Account}:table/${TableName}/backup/${BackupName}", True} |
|
@kmcquade made changes , please review again. |
kmcquade
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#237
What gif best describes this PR or how it makes you feel?
http://gph.is/2jt9RvW
<iframe src="https://giphy.com/embed/11ZSwQNWba4YF2" width="247" height="480" frameBorder="0" class="giphy-embed" allowFullScreen></iframe>via GIPHY
[//]: # (Encouraged: Insert an appropriate gif/meme to brighten up your reviewer's day.)Completion checklist