Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected output when working with ARNs that have a path in them #284

Merged
merged 45 commits into from
Nov 18, 2020
Merged

Unexpected output when working with ARNs that have a path in them #284

merged 45 commits into from
Nov 18, 2020

Commits on Sep 29, 2020

  1. Non-working tests and adjustments to fix salesforce#237.

    @kmcquade
    kmcquade committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    0c15cc7 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. Update database (salesforce#241) 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @github-actions @saikirankv
    github-actions[bot] authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    8658db4 View commit details
    Browse the repository at this point in the history

  2. Speed improvements by changing IAM definition - fixes salesforce#240 (s… 

    …alesforce#242)

* Changes to IAM Definition - so far untested and have not adjusted query methods

* Speed improvements by changing the IAM definition

* Make pylint happy

* Refresh docs and fix tests

* Version bump
    @kmcquade @saikirankv
    kmcquade authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    3b087a6 View commit details
    Browse the repository at this point in the history

  3. update brew formula

    @actions-user @saikirankv
    actions-user authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    1d3207f View commit details
    Browse the repository at this point in the history

  4. Fix homebrew publishing

    @kmcquade @saikirankv
    kmcquade authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    bea972b View commit details
    Browse the repository at this point in the history

  5. renaming github action test.yml to ci.yml and name to continuous-inte… 

    …gration (salesforce#247)

* renaming test.yml to ci.yaml
    @reetasingh @saikirankv
    reetasingh authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    50a974c View commit details
    Browse the repository at this point in the history

  6. fix None type scenario in get_actions_for_service (salesforce#246) 

    * fix NoneType error in get_actions_for_service
    @reetasingh @saikirankv
    reetasingh authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    8ad8d6e View commit details
    Browse the repository at this point in the history

  7. updating build badge to github actions CI badge in README.md (salesfo… 

    …rce#249)

* fix exception handling in get_action_for_service

* update readme
    @reetasingh @saikirankv
    reetasingh authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    cfb6264 View commit details
    Browse the repository at this point in the history

  8. adding unit tests for util/conditions.py is_condition_key_match method ( 

    salesforce#250)

* fix exception handling in get_action_for_service

* adding unit tests

* rename unit test file
    @reetasingh @saikirankv
    reetasingh authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    7d26d96 View commit details
    Browse the repository at this point in the history

  9. Fix IAM definition update code (salesforce#254) 

    update awsdocs.py for new AWS formatting changes
    @reetasingh @saikirankv
    reetasingh authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    180ae03 View commit details
    Browse the repository at this point in the history

  10. Made updates to the scraping logic for the Actions, Resources, and Co… 

    …ndition Keys. Future-proofed some unit tests to prevent them from breaking after AWS updates their docs. (salesforce#258)

Related to salesforce#256
    @kmcquade @saikirankv
    kmcquade authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    6ab403a View commit details
    Browse the repository at this point in the history

  11. Improving minimization by grouping results based on arns (salesforce#252 

    )

* Improved minimization
    @saikirankv
    saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    256242d View commit details
    Browse the repository at this point in the history

  12. Ensured minimization won't break if resource path contains special ch… 

    …aracters and improve the unit tests for minimization (salesforce#259)

* Ensured minimization won't break if resource path contains special characters; improve the unit tests for minimization

* Added more test cases for the minimizing functions
    @kmcquade @saikirankv
    kmcquade authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    909eb2c View commit details
    Browse the repository at this point in the history

  13. Added click unit tests (salesforce#262)

    @kmcquade @saikirankv
    kmcquade authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    ff4006f View commit details
    Browse the repository at this point in the history

  14. Add --resource-type flag to policy_sentry query action-table comm… 

    …and (salesforce#261)

* add resource type flag in query action-table

* add unit test

* updating doc for resource-type param
    @reetasingh @saikirankv
    reetasingh authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    1704ab1 View commit details
    Browse the repository at this point in the history

  15. fix cheat sheet for resource type (salesforce#265)

    @reetasingh @saikirankv
    reetasingh authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    4eb2312 View commit details
    Browse the repository at this point in the history

  16. Updates to support calling policy_sentry from a terraform external da… 

    …ta source; added --fmt terraform which outputs policy as a json string embedded in json; allowed --minimize to accept a negative value to denote None (salesforce#263)
    @dgubitosi @saikirankv
    dgubitosi authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    b5ccd54 View commit details
    Browse the repository at this point in the history

  17. Provide fix for SID that contains dash (salesforce#267) 

    fixes salesforce#266
    @Alegrowin @saikirankv
    Alegrowin authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    b1f931b View commit details
    Browse the repository at this point in the history

  18. fix logging bug (salesforce#269) 

    Fix logging
    @reetasingh @saikirankv
    reetasingh authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    06e10b7 View commit details
    Browse the repository at this point in the history

  19. Update CHANGELOG.md

    @kmcquade @saikirankv
    kmcquade authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    7cc7db3 View commit details
    Browse the repository at this point in the history

  20. Change minimize to a boolean flag with an option minimize-length argu… 

    …ment
    @dgubitosi @saikirankv
    dgubitosi authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    8e58303 View commit details
    Browse the repository at this point in the history

  21. backward compatibility for --minimize

    @dgubitosi @saikirankv
    dgubitosi authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    88c5a7c View commit details
    Browse the repository at this point in the history

  22. remove --no-minimize

    @dgubitosi @saikirankv
    dgubitosi authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    5cb5512 View commit details
    Browse the repository at this point in the history

  23. is_eager is not needed here

    @dgubitosi @saikirankv
    dgubitosi authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    56ce0bf View commit details
    Browse the repository at this point in the history

  24. use custom classes for proper backward compatibility for --minimize

    @dgubitosi @saikirankv
    dgubitosi authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    f1a95d8 View commit details
    Browse the repository at this point in the history

  25. ensure argument order remains consistent

    @dgubitosi @saikirankv
    dgubitosi authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    4c396fd View commit details
    Browse the repository at this point in the history

  26. fix pylint errors

    @dgubitosi @saikirankv
    dgubitosi authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    3b46f5a View commit details
    Browse the repository at this point in the history

  27. fix last pylint error

    @dgubitosi @saikirankv
    dgubitosi authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    e2345a8 View commit details
    Browse the repository at this point in the history

  28. increment version to 0.10.0

    @dgubitosi @saikirankv
    dgubitosi authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    90e62d8 View commit details
    Browse the repository at this point in the history

  29. update brew formula

    @actions-user @saikirankv
    actions-user authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    d64f53c View commit details
    Browse the repository at this point in the history

  30. adding release drafter github action (salesforce#260) 

    * adding release drafter

* adding release-drafter github action

* updating docs link
    @reetasingh @saikirankv
    reetasingh authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    9a598e1 View commit details
    Browse the repository at this point in the history

  31. Update database (salesforce#271) 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @github-actions @saikirankv
    github-actions[bot] authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    83f49fe View commit details
    Browse the repository at this point in the history

  32. update brew formula

    @actions-user @saikirankv
    actions-user authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    e6f504b View commit details
    Browse the repository at this point in the history

  33. docs formatting (salesforce#273)

    @plaguna @saikirankv
    plaguna authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    7d08fa3 View commit details
    Browse the repository at this point in the history

  34. removing CHANGELOG.md

    @reetasingh @saikirankv
    reetasingh authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    b7a98e8 View commit details
    Browse the repository at this point in the history

  35. Migrate terraform module (salesforce#277) 

    Migrate Terraform module to salesforce org; Clean up .gitignore
    @kmcquade @saikirankv
    kmcquade authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    bc09697 View commit details
    Browse the repository at this point in the history

  36. Terraform: Add support for skip_resource_constraints and exclude_acti… 

    …ons - Fixes salesforce#278 (salesforce#279)

* Clean up variables file and readme in Terraform modules

* Fixes salesforce#278 - improved IAM policy output format, added exclude_actions and skip_resource_constraints fields
    @kmcquade @saikirankv
    kmcquade authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    a99674c View commit details
    Browse the repository at this point in the history

  37. Adds support for Terraform 0.13

    @kmcquade @saikirankv
    kmcquade authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    7435597 View commit details
    Browse the repository at this point in the history

  38. Minimize is set to true by default for the Terraform module

    @kmcquade @saikirankv
    kmcquade authored and saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    1cab8ab View commit details
    Browse the repository at this point in the history

  39. Resolving conflicts

    @saikirankv
    saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    b280b0d View commit details
    Browse the repository at this point in the history

  40. Unexpected output when working with ARNs that have a path in them

    @saikirankv
    saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    a9d959d View commit details
    Browse the repository at this point in the history

  41. fixing failing testcases

    @saikirankv
    saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    dc5c773 View commit details
    Browse the repository at this point in the history

  42. pylint changes

    @saikirankv
    saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    f984dd7 View commit details
    Browse the repository at this point in the history

  43. version increment

    @saikirankv
    saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    3c0b398 View commit details
    Browse the repository at this point in the history

  44. Review changes

    @saikirankv
    saikirankv committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    8e07aea View commit details
    Browse the repository at this point in the history