implement post token UI #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamigo
suggested changes
Dec 9, 2016
view/tokens/new.pug
Outdated
| doctype html | ||
| html | ||
| head | ||
| title Create new token |
view/tokens/app.js
Outdated
| toggleVisibility(successInfo, true); | ||
| toggleVisibility(tokenInfo, true); | ||
| successInfo.innerHTML = 'Token generated from ' + res.body.name + | ||
| '. Please save this token, you will not see this token again!'; |
There was a problem hiding this comment.
how about something like this:
<b>Copy and paste your new token somewhere safe--you will not be able to see it again!</b>
Token name: ________
Token value: __________________
| #successInfo | ||
| #tokenInfo | ||
| .form-group | ||
| input.form-control(type='text', autofocus, name="name", maxlength='60' placeholder='Enter token name' required) |
There was a problem hiding this comment.
When you get back the token value, can we put a little more vertical space and maybe even a horizontal line between the new token that gets returned and the form fields where you enter a name to create yet another new token?
|
@iamigo Updated style. Screenshots are attached. |
iamigo
previously requested changes
Dec 13, 2016
| @@ -0,0 +1,34 @@ | |||
| /** | |||
iamigo
approved these changes
Dec 13, 2016
|
Comments @shriramshankar ? |
| } | ||
| #formGroup.show { | ||
| margin: 20px 0; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Needs a new line at the end of the file. Sorry for nit picking.
|
@shriramshankar waiting for review |
|
@iamigo left a comment yesterday. Ok, to merge if we do not want to take care of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this for Anny since she can't login to github right now