enable socketio clients to communicate with client using only the protocols set in the config

[shriramshankar]

No description provided.

[coveralls]

Coverage increased (+0.007%) to 83.37% when pulling 94126a9 on socketio-polling into a402180 on master.

[coveralls]

Coverage increased (+0.007%) to 83.37% when pulling 94126a9 on socketio-polling into a402180 on master.

[shriramshankar]

All the changes are here. Will do the any other requested changes after my training tomorrow.

[coveralls]

Coverage increased (+0.007%) to 83.37% when pulling 1e03469 on socketio-polling into a402180 on master.

[iamigo]

Why using string 'undefined' here? It seems like it has potential for misunderstanding given javascript's "undefined" reserved word. I would rather see something like this:

const socketIOtransportProtocol = pe.SOCKETIO_TRANSPORT_PROTOCOL || null;

or

const socketIOtransportProtocol = pe.SOCKETIO_TRANSPORT_PROTOCOL || '';

... and then in app.js line 105, just check for if (clientProtocol) {

[iamigo]

Can you add a comment about this regex and the format the socket.io options.transports requires?

[shriramshankar]

pr updated
@theswamis added the option to force client to use websocket using the query param.
@iamigo used '' instead of undefined.

[coveralls]

Coverage increased (+0.007%) to 83.37% when pulling fef5e50 on socketio-polling into a402180 on master.

[shriramshankar]

?protocol=websocket is the query param to force the client to communicate over websocket.

[shriramshankar]

@pallavi2209 @iamigo web concurrency also seems to be working. Can you check if it set the config var right ? I set WEB_CONCURRENCY = 2.

[coveralls]

Coverage increased (+0.007%) to 83.37% when pulling 29ee2fa on socketio-polling into e2d4e2c on master.

[pallavi2209]

@shriramshankar Thats great! The config var looks right to me.