feat: prompt user to select lightning experince app #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maliroteh-sf
commented
Oct 9, 2024
Comment on lines
+63
to
+82
| const appMenuItemsQuery = | ||
| 'SELECT Label,Description,Name FROM AppMenuItem WHERE IsAccessible=true AND IsVisible=TRUE'; | ||
| const appMenuItems = await connection.query<{ Label: string; Description: string; Name: string }>( | ||
| appMenuItemsQuery | ||
| ); | ||
|
|
||
| const appDefinitionsQuery = "SELECT DeveloperName,DurableId FROM AppDefinition WHERE UiType='Lightning'"; | ||
| const appDefinitions = await connection.query<{ DeveloperName: string; DurableId: string }>(appDefinitionsQuery); | ||
|
|
||
| appMenuItems.records.forEach((item) => { | ||
| const match = appDefinitions.records.find((definition) => definition.DeveloperName === item.Name); | ||
| if (match) { | ||
| results.push({ | ||
| DeveloperName: match.DeveloperName, | ||
| Label: item.Label, | ||
| Description: item.Description, | ||
| DurableId: match.DurableId, | ||
| }); | ||
| } | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
Ideally we would do all of this in a single SQL statement using JOIN but as I understand it SF SOQL statements don't support JOIN so instead I run 2 query and filter in code (since it won't be the case that an org would have thousands and thousands of apps... but rather a handful of apps)
| // The appName is optional but if the user did provide an appName then it must be | ||
| // a valid one.... meaning that it should resolve to a valid appId. | ||
| const appId = await OrgUtils.getAppDefinitionDurableId(connection, appName); | ||
| if (!appId) { |
There was a problem hiding this comment.
If appName is not valid, should user be prompted too?
Contributor
Author
There was a problem hiding this comment.
That's not part of the UX design so we error out instead (which is consistent with the behavior of the Beta version).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If no value is provided for the flag
--namethen interactively prompts the user to select a lightning experience app.What issues does this PR fix or reference?
@W-16599797@