Skip to content

Conversation

@ravijayaramappa
Copy link
Collaborator

@ravijayaramappa ravijayaramappa commented Oct 14, 2024

What does this PR do?

BREAKING CHANGE: this version works with 254(spring25) release and newer

@W-16974485@

BREAKING CHANGE: this version works with 254(spring25) release and newer
@ravijayaramappa ravijayaramappa requested a review from a team as a code owner October 14, 2024 18:56
@ravijayaramappa ravijayaramappa changed the title feat!: 254 code line cut over, main now tracks 254(spring25) codeline feat!: 254 code line cut over, main now tracks 254(spring25) codeline @W-16974485 Oct 14, 2024
@ravijayaramappa ravijayaramappa changed the title feat!: 254 code line cut over, main now tracks 254(spring25) codeline @W-16974485 feat!: 254 code line cut over, main now tracks 254(spring25) codeline @W-16974485@ Oct 14, 2024
Copy link
Contributor

@maliroteh-sf maliroteh-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo but other than that LGTM

CONTRIBUTING.md Outdated

### Branches

The primary working branch for this repo is the `main` branch. This branch branch tracks the in-development branch of core. The patch branches are named `252-patch` and such. The patch branches track the production branches of core. A new patch branch is created at Code Line Cut Over(CLCO).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: This branch branch tracks ...

Copy link
Collaborator

@nrkruk nrkruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so when we push this change, it should automatically update main to be version 2 (due to listing this as a breaking change / conventional commits). Looks good

@ravijayaramappa ravijayaramappa merged commit 20994b9 into main Oct 15, 2024
11 checks passed
@ravijayaramappa ravijayaramappa deleted the ravi/main/clco branch October 15, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants