fix: remove lightning-base-components dependency @W-19861266@ #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove lightning-base-components from package.json dependencies - Remove lightning-base-components from lwc.config.json modules - Update yarn.lock to reflect dependency removal
nrkruk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the unused lightning-base-components dependency from the plugin-lightning-dev package.
What issues does this PR fix or reference?
The lightning-base-components package was not being imported or used anywhere in the source code, making it safe to remove. This helps reduce the plugin's bundle size and eliminates an unnecessary dependency.
@W-19861266@