Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update linking #555

Merged
merged 2 commits into from
Feb 24, 2017
Merged

update linking #555

merged 2 commits into from
Feb 24, 2017

Conversation

mcshane
Copy link
Contributor

@mcshane mcshane commented Feb 23, 2017

  1. Use -Wl,-export_dynamic instead of -rdynamic on macOS

See #388 and https://sourceforge.net/p/samtools/mailman/message/34699333/

  1. Always link with -rdynamic/-ldl

See samtools/samtools@3c15c88, #549 and #482.

@pd3 pd3 merged commit 1b1a271 into develop Feb 24, 2017
@mcshane mcshane deleted the feature/make branch February 24, 2017 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcshane @pd3