Initialized ansible playbook integration #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelliot
requested changes
Aug 24, 2025
- Removed redundant checks for installation status and required files, as these are handled by Firewheel. - Retained core functionality for creating directories, downloading files, generating SSH keys, and compressing profiles. - Simplified logic to streamline the playbook and avoid unnecessary complexity. - Ignored validation for tmux-cssh, as it is not explicitly checked in the original Bash script. - Ensured alignment with the original Bash script while meeting pull request requirements.
…cts based on MANIFEST constraints - Updated required_files lists for Ubuntu Jammy, Ubuntu Trusty, and Linux Base Objects based on MANIFEST specifications and vm_resources directory contents. - Ensured alignment with MANIFEST constraints (e.g., *.py, *.sh, *.tgz, vm_resources/*). - Removed redundant checks for installation status and required files, as these are handled by Firewheel. - Retained core functionality for creating directories, downloading files, compressing tarballs, and cleaning up. - Simplified logic to streamline the playbooks and avoid unnecessary complexity.
…stead of vm_resources_dir
sdelliot
requested changes
Sep 8, 2025
sdelliot
requested changes
Sep 9, 2025
sdelliot
reviewed
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current State
Currently, some Model Components may require additional data to be downloaded (e.g., VM resources, etc.) that cannot or should not be stored within the MC repo package. In this case, the Model Components can have an INSTALL file, which can be any executable script (as denoted by a shebang line). See: Model Component INSTALL file.
This PR enables using Ansible playbooks in lieu of using a bash-based script in line with the ansible update to firewheel (see here).
Primary Benefits
There are several primary motivators for this change:
Key Changes
A new Ansible install playbook directory for this model component in place of the previous install bash script.