Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): upgrade react-rx to v3 #6883

Merged
merged 1 commit into from
Jun 12, 2024
Merged

feat(deps): upgrade react-rx to v3 #6883

merged 1 commit into from
Jun 12, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Jun 9, 2024

Upgrade to a new major of react-rx that's more performant on React 18, and more stable on React 19 strict mode.

The useMemoObservable and useObservableCallback hooks can't be optimized by the React Compiler. Thus they are replaced with useMemo + useObservable, and useObservableEvent replaces useObservableCallback and uses a ponyfill of the upcoming React.useEffectEvent hook 🙌

Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 9:32am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 9:32am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 9:32am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 9:32am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 9:32am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 9:32am

Copy link
Contributor

github-actions bot commented Jun 9, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Jun 9, 2024

Component Testing Report Updated Jun 12, 2024 9:36 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 37s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 17s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 31s 12 0 0

Co-Authored-By: Bjørge Næss <876086+bjoerge@users.noreply.github.com>
@@ -17,8 +17,7 @@
"check:deps": "pnpm --recursive --parallel exec depcheck",
"check:format": "prettier . --check",
"check:lint": "turbo run lint --continue -- --quiet",
"check:react-exhaustive-deps": "turbo run lint --continue -- --quiet --rule 'react-hooks/exhaustive-deps: [error, {additionalHooks: \"(useMemoObservable|useObservableCallback)\"}]'",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check isn't needed anymore as check:react-compiler covers that and more, and is also run on the CI

@stipsan stipsan added this pull request to the merge queue Jun 12, 2024
Merged via the queue into next with commit a5cabb6 Jun 12, 2024
45 checks passed
@stipsan stipsan deleted the upgrade-react-rx-major branch June 12, 2024 17:53
juice49 pushed a commit that referenced this pull request Jun 13, 2024
Co-authored-by: Bjørge Næss <876086+bjoerge@users.noreply.github.com>
pedrobonamin added a commit that referenced this pull request Jun 26, 2024
* feat(structure): add sheet list publish action
pending items:
- validate user permissions for publish
- validate document

* feat(structure): add publish action popover and validation to documents rows

* fix(structure): update sheet list select column

* feat(structure): edx-1313 - clicking on a row opens the document

* fix(structure): move preview to it's own file, fix title

* fix(structure): refactor paneItemPreview to create it's own title

* add selected state to rows

* fix(structure): sheet list headers reduce height

* feat(structure): add column resizing to sheet list table EDX-1452

* fix(structure): update how selected rows border is generated

* fix(structure): when hiding parent column, hide all children

* fix(structure): ui update to sheet list table actions

* feat(structure): sheet list view patching (#6866)

* feat(structure): escape cancels changes to value

* feat(structure): add sheet list publish action
pending items:
- validate user permissions for publish
- validate document

* feat(structure): add publish action popover and validation to documents rows

* fix(structure): update sheet list select column

* feat(structure): edx-1313 - clicking on a row opens the document

* fix(structure): move preview to it's own file, fix title

* fix(structure): refactor paneItemPreview to create it's own title

* add selected state to rows

* fix(structure): sheet list headers reduce height

* feat(structure): add column resizing to sheet list table EDX-1452

* fix(structure): update how selected rows border is generated

* fix(structure): when hiding parent column, hide all children

* fix(structure): ui update to sheet list table actions

* feat(structure): sheet list view patching (#6866)

* chore(structure): update exports and remove unnecesary imports, fix build issues

* feat(structure): delete key deletes values

* feat(structure): reverting unintended import change

* fix(structure): memoize items ids value in documentSheetActions

* fix(structure): update how actions popover width is calculated, use matchReferenceWidth

* fix(structure): add tests for nested header hiding action

* fix(structure): update previewTitle fallback in paneItemPreview

* feat(structure): add unset document value into sheetlist

* feat(structure): select and focus styling for cells

* feat(structure): removing unused method for border styles

* refactor(structure): removing sheetCellInner and moving to SheetCell

* refactor(structure): reusing existing primitive type assertion

* feat(structure): parsing field values to field types

* feat(structure): parsing field values to field types

* fix(structure): fixing issue where real time updates only happened if value already existed

* feat(structure): number inputs allow for default behavior

* fix(structure): update selected sheets styles, add disableCellFocus property

* refactor(structure); fixing failing sheet list pane tests

* feat(structure): sheet list delete and cancel cell edits (#6890)

* feat(structure): escape cancels changes to value

* feat(structure): delete key deletes values

* feat(structure): add unset document value into sheetlist

---------

Co-authored-by: Pedro Bonamin <pedrobonamin@gmail.com>

* feat(structure): add support for boolean inputs (#6898)

* feat(structure): add support for boolean inputs

* chore(deps): dedupe pnpm-lock.yaml (#6916)

Co-authored-by: juice49 <1454914+juice49@users.noreply.github.com>

* chore(deps): update dependency @sanity/tsdoc to v1.0.72 (#6911)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(deps): upgrade react-rx to v3 (#6883)

Co-authored-by: Bjørge Næss <876086+bjoerge@users.noreply.github.com>

* fix(deps): Update dev-non-major (#6915)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(structure): using upgraded react-rx

* Sheet dropdown (#6955)

* refactor(structure): fixing issue with react-compiler and mutated reference

* refactor(structure): passing ref to cellInput

* feat(structure): supporting string and number dropdowns

* fix(structure): fixing issue where copy on focused cells wasn't happening

* fix(structure): resolving unsetting issues with sheet list inputs

* feat(structure): radio selects don't allow unset value

* fix(structure): use ref for all sheet cells for focusing

* fix(structure): correcting using types in tanstack type def

* feat(structure): translations for sheet list (#6972)

* feat(structure): translations for sheet list actions

* feat(structure): translations for sheet list

* feat(structure): creating separate namespace for sheet list locale

* feat(structure): add validation to sheet list cell (#6933)

* feat(structure): add validation to sheet list cell

* feat(structure): show validation icon only on cell hover

* fix(structure): update sheet list validation level function

Co-authored-by: Jordan Lawrence <jordanl17@me.com>

* chore(structure): remove comment

---------

Co-authored-by: Jordan Lawrence <jordanl17@me.com>

* chore(structure): disable sheet list view if no schemaType is found

* feat(structure): read only sheet (#6954)

* refactor(structure): fixing issue with react-compiler and mutated reference

* refactor(structure): passing ref to cellInput

* feat(structure): supporting string and number dropdowns

* fix(structure): fixing issue where copy on focused cells wasn't happening

* fix(structure): resolving unsetting issues with sheet list inputs

* feat(structure): radio selects don't allow unset value

* fix(structure): use ref for all sheet cells for focusing

* fix(structure): correcting using types in tanstack type def

* feat(structure): supporting read only inputs in sheet list

* Sheet dropdown (#6955)

* refactor(structure): fixing issue with react-compiler and mutated reference

* refactor(structure): passing ref to cellInput

* feat(structure): supporting string and number dropdowns

* fix(structure): fixing issue where copy on focused cells wasn't happening

* fix(structure): resolving unsetting issues with sheet list inputs

* feat(structure): radio selects don't allow unset value

* fix(structure): use ref for all sheet cells for focusing

* fix(structure): correcting using types in tanstack type def

* feat(structure): fixing styling for input cell field

* test(structure): testing for read only

* test(structure): testing for different text types

* test(structure): testing for boolean cells

* feat(structure): supporting unset across all sheet fields

* feat(structure): testing for radio selects

* feat(structure): testing when deleting on dropdown

* refactor(structure): lifting up read only operation blocking to list pane

* fix(structure): adding CellValidation back to SheetListCell

* fix(structure): update tests and remove unnecessary file

---------

Co-authored-by: jordanl17 <jordanl17@me.com>
Co-authored-by: ecospark[bot] <128108030+ecospark[bot]@users.noreply.github.com>
Co-authored-by: juice49 <1454914+juice49@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Cody Olsen <81981+stipsan@users.noreply.github.com>
Co-authored-by: Bjørge Næss <876086+bjoerge@users.noreply.github.com>
pedrobonamin added a commit that referenced this pull request Jun 27, 2024
* feat(structure): add sheet list publish action
pending items:
- validate user permissions for publish
- validate document

* feat(structure): add publish action popover and validation to documents rows

* fix(structure): update sheet list select column

* feat(structure): edx-1313 - clicking on a row opens the document

* fix(structure): move preview to it's own file, fix title

* fix(structure): refactor paneItemPreview to create it's own title

* add selected state to rows

* fix(structure): sheet list headers reduce height

* feat(structure): add column resizing to sheet list table EDX-1452

* fix(structure): update how selected rows border is generated

* fix(structure): when hiding parent column, hide all children

* fix(structure): ui update to sheet list table actions

* feat(structure): sheet list view patching (#6866)

* feat(structure): escape cancels changes to value

* feat(structure): add sheet list publish action
pending items:
- validate user permissions for publish
- validate document

* feat(structure): add publish action popover and validation to documents rows

* fix(structure): update sheet list select column

* feat(structure): edx-1313 - clicking on a row opens the document

* fix(structure): move preview to it's own file, fix title

* fix(structure): refactor paneItemPreview to create it's own title

* add selected state to rows

* fix(structure): sheet list headers reduce height

* feat(structure): add column resizing to sheet list table EDX-1452

* fix(structure): update how selected rows border is generated

* fix(structure): when hiding parent column, hide all children

* fix(structure): ui update to sheet list table actions

* feat(structure): sheet list view patching (#6866)

* chore(structure): update exports and remove unnecesary imports, fix build issues

* feat(structure): delete key deletes values

* feat(structure): reverting unintended import change

* fix(structure): memoize items ids value in documentSheetActions

* fix(structure): update how actions popover width is calculated, use matchReferenceWidth

* fix(structure): add tests for nested header hiding action

* fix(structure): update previewTitle fallback in paneItemPreview

* feat(structure): add unset document value into sheetlist

* feat(structure): select and focus styling for cells

* feat(structure): removing unused method for border styles

* refactor(structure): removing sheetCellInner and moving to SheetCell

* refactor(structure): reusing existing primitive type assertion

* feat(structure): parsing field values to field types

* feat(structure): parsing field values to field types

* fix(structure): fixing issue where real time updates only happened if value already existed

* feat(structure): number inputs allow for default behavior

* fix(structure): update selected sheets styles, add disableCellFocus property

* refactor(structure); fixing failing sheet list pane tests

* feat(structure): sheet list delete and cancel cell edits (#6890)

* feat(structure): escape cancels changes to value

* feat(structure): delete key deletes values

* feat(structure): add unset document value into sheetlist

---------

Co-authored-by: Pedro Bonamin <pedrobonamin@gmail.com>

* feat(structure): add support for boolean inputs (#6898)

* feat(structure): add support for boolean inputs

* chore(deps): dedupe pnpm-lock.yaml (#6916)

Co-authored-by: juice49 <1454914+juice49@users.noreply.github.com>

* chore(deps): update dependency @sanity/tsdoc to v1.0.72 (#6911)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(deps): upgrade react-rx to v3 (#6883)

Co-authored-by: Bjørge Næss <876086+bjoerge@users.noreply.github.com>

* fix(deps): Update dev-non-major (#6915)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(structure): using upgraded react-rx

* Sheet dropdown (#6955)

* refactor(structure): fixing issue with react-compiler and mutated reference

* refactor(structure): passing ref to cellInput

* feat(structure): supporting string and number dropdowns

* fix(structure): fixing issue where copy on focused cells wasn't happening

* fix(structure): resolving unsetting issues with sheet list inputs

* feat(structure): radio selects don't allow unset value

* fix(structure): use ref for all sheet cells for focusing

* fix(structure): correcting using types in tanstack type def

* feat(structure): translations for sheet list (#6972)

* feat(structure): translations for sheet list actions

* feat(structure): translations for sheet list

* feat(structure): creating separate namespace for sheet list locale

* feat(structure): add validation to sheet list cell (#6933)

* feat(structure): add validation to sheet list cell

* feat(structure): show validation icon only on cell hover

* fix(structure): update sheet list validation level function

Co-authored-by: Jordan Lawrence <jordanl17@me.com>

* chore(structure): remove comment

---------

Co-authored-by: Jordan Lawrence <jordanl17@me.com>

* chore(structure): disable sheet list view if no schemaType is found

* feat(structure): read only sheet (#6954)

* refactor(structure): fixing issue with react-compiler and mutated reference

* refactor(structure): passing ref to cellInput

* feat(structure): supporting string and number dropdowns

* fix(structure): fixing issue where copy on focused cells wasn't happening

* fix(structure): resolving unsetting issues with sheet list inputs

* feat(structure): radio selects don't allow unset value

* fix(structure): use ref for all sheet cells for focusing

* fix(structure): correcting using types in tanstack type def

* feat(structure): supporting read only inputs in sheet list

* Sheet dropdown (#6955)

* refactor(structure): fixing issue with react-compiler and mutated reference

* refactor(structure): passing ref to cellInput

* feat(structure): supporting string and number dropdowns

* fix(structure): fixing issue where copy on focused cells wasn't happening

* fix(structure): resolving unsetting issues with sheet list inputs

* feat(structure): radio selects don't allow unset value

* fix(structure): use ref for all sheet cells for focusing

* fix(structure): correcting using types in tanstack type def

* feat(structure): fixing styling for input cell field

* test(structure): testing for read only

* test(structure): testing for different text types

* test(structure): testing for boolean cells

* feat(structure): supporting unset across all sheet fields

* feat(structure): testing for radio selects

* feat(structure): testing when deleting on dropdown

* refactor(structure): lifting up read only operation blocking to list pane

* fix(structure): adding CellValidation back to SheetListCell

* fix(structure): update tests and remove unnecessary file

---------

Co-authored-by: jordanl17 <jordanl17@me.com>
Co-authored-by: ecospark[bot] <128108030+ecospark[bot]@users.noreply.github.com>
Co-authored-by: juice49 <1454914+juice49@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Cody Olsen <81981+stipsan@users.noreply.github.com>
Co-authored-by: Bjørge Næss <876086+bjoerge@users.noreply.github.com>
jordanl17 added a commit that referenced this pull request Jul 3, 2024
* feat(structure): add sheet list publish action
pending items:
- validate user permissions for publish
- validate document

* feat(structure): add publish action popover and validation to documents rows

* fix(structure): update sheet list select column

* feat(structure): edx-1313 - clicking on a row opens the document

* fix(structure): move preview to it's own file, fix title

* fix(structure): refactor paneItemPreview to create it's own title

* add selected state to rows

* fix(structure): sheet list headers reduce height

* feat(structure): add column resizing to sheet list table EDX-1452

* fix(structure): update how selected rows border is generated

* fix(structure): when hiding parent column, hide all children

* fix(structure): ui update to sheet list table actions

* feat(structure): sheet list view patching (#6866)

* feat(structure): escape cancels changes to value

* feat(structure): add sheet list publish action
pending items:
- validate user permissions for publish
- validate document

* feat(structure): add publish action popover and validation to documents rows

* fix(structure): update sheet list select column

* feat(structure): edx-1313 - clicking on a row opens the document

* fix(structure): move preview to it's own file, fix title

* fix(structure): refactor paneItemPreview to create it's own title

* add selected state to rows

* fix(structure): sheet list headers reduce height

* feat(structure): add column resizing to sheet list table EDX-1452

* fix(structure): update how selected rows border is generated

* fix(structure): when hiding parent column, hide all children

* fix(structure): ui update to sheet list table actions

* feat(structure): sheet list view patching (#6866)

* chore(structure): update exports and remove unnecesary imports, fix build issues

* feat(structure): delete key deletes values

* feat(structure): reverting unintended import change

* fix(structure): memoize items ids value in documentSheetActions

* fix(structure): update how actions popover width is calculated, use matchReferenceWidth

* fix(structure): add tests for nested header hiding action

* fix(structure): update previewTitle fallback in paneItemPreview

* feat(structure): add unset document value into sheetlist

* feat(structure): select and focus styling for cells

* feat(structure): removing unused method for border styles

* refactor(structure): removing sheetCellInner and moving to SheetCell

* refactor(structure): reusing existing primitive type assertion

* feat(structure): parsing field values to field types

* feat(structure): parsing field values to field types

* fix(structure): fixing issue where real time updates only happened if value already existed

* feat(structure): number inputs allow for default behavior

* fix(structure): update selected sheets styles, add disableCellFocus property

* refactor(structure); fixing failing sheet list pane tests

* feat(structure): sheet list delete and cancel cell edits (#6890)

* feat(structure): escape cancels changes to value

* feat(structure): delete key deletes values

* feat(structure): add unset document value into sheetlist

---------

Co-authored-by: Pedro Bonamin <pedrobonamin@gmail.com>

* feat(structure): add support for boolean inputs (#6898)

* feat(structure): add support for boolean inputs

* chore(deps): dedupe pnpm-lock.yaml (#6916)

Co-authored-by: juice49 <1454914+juice49@users.noreply.github.com>

* chore(deps): update dependency @sanity/tsdoc to v1.0.72 (#6911)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(deps): upgrade react-rx to v3 (#6883)

Co-authored-by: Bjørge Næss <876086+bjoerge@users.noreply.github.com>

* fix(deps): Update dev-non-major (#6915)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(structure): using upgraded react-rx

* Sheet dropdown (#6955)

* refactor(structure): fixing issue with react-compiler and mutated reference

* refactor(structure): passing ref to cellInput

* feat(structure): supporting string and number dropdowns

* fix(structure): fixing issue where copy on focused cells wasn't happening

* fix(structure): resolving unsetting issues with sheet list inputs

* feat(structure): radio selects don't allow unset value

* fix(structure): use ref for all sheet cells for focusing

* fix(structure): correcting using types in tanstack type def

* feat(structure): sorting sheet list using search order

* feat(structure): fixing sheet list loading state

* feat(structure): fixing test to use sort order

* feat(structure): reverting skipped test

* feat(structure): refactor to reuse in sheet list and list

* feat(structure): translations for sheet list (#6972)

* feat(structure): translations for sheet list actions

* feat(structure): translations for sheet list

* feat(structure): creating separate namespace for sheet list locale

* fix(core): update url for notify endpoint (#7022)

* chore(page-building): clean up schema types (#6973)

* feat(structure): add validation to sheet list cell (#6933)

* feat(structure): add validation to sheet list cell

* feat(structure): show validation icon only on cell hover

* fix(structure): update sheet list validation level function

Co-authored-by: Jordan Lawrence <jordanl17@me.com>

* chore(structure): remove comment

---------

Co-authored-by: Jordan Lawrence <jordanl17@me.com>

* chore(structure): disable sheet list view if no schemaType is found

* feat(structure): add sheet list publish action
pending items:
- validate user permissions for publish
- validate document

* feat(structure): add publish action popover and validation to documents rows

* fix(structure): update sheet list select column

* feat(structure): edx-1313 - clicking on a row opens the document

* fix(structure): move preview to it's own file, fix title

* fix(structure): refactor paneItemPreview to create it's own title

* add selected state to rows

* fix(structure): sheet list headers reduce height

* feat(structure): add column resizing to sheet list table EDX-1452

* fix(structure): update how selected rows border is generated

* fix(structure): when hiding parent column, hide all children

* fix(structure): ui update to sheet list table actions

* feat(structure): sheet list view patching (#6866)

* chore(structure): update exports and remove unnecesary imports, fix build issues

* fix(structure): memoize items ids value in documentSheetActions

* fix(structure): update how actions popover width is calculated, use matchReferenceWidth

* fix(structure): add tests for nested header hiding action

* fix(structure): update previewTitle fallback in paneItemPreview

* feat(structure): sheet list delete and cancel cell edits (#6890)

* feat(structure): escape cancels changes to value

* feat(structure): delete key deletes values

* feat(structure): add unset document value into sheetlist

---------

Co-authored-by: Pedro Bonamin <pedrobonamin@gmail.com>

* fix(structure): when documents are added, add them to sheet list (#6944)

* fix(structure): when documents are added, add them to the sheet list data

* fix(structure): update paneContainer test

* feat(structure): read only sheet (#6954)

* refactor(structure): fixing issue with react-compiler and mutated reference

* refactor(structure): passing ref to cellInput

* feat(structure): supporting string and number dropdowns

* fix(structure): fixing issue where copy on focused cells wasn't happening

* fix(structure): resolving unsetting issues with sheet list inputs

* feat(structure): radio selects don't allow unset value

* fix(structure): use ref for all sheet cells for focusing

* fix(structure): correcting using types in tanstack type def

* feat(structure): supporting read only inputs in sheet list

* Sheet dropdown (#6955)

* refactor(structure): fixing issue with react-compiler and mutated reference

* refactor(structure): passing ref to cellInput

* feat(structure): supporting string and number dropdowns

* fix(structure): fixing issue where copy on focused cells wasn't happening

* fix(structure): resolving unsetting issues with sheet list inputs

* feat(structure): radio selects don't allow unset value

* fix(structure): use ref for all sheet cells for focusing

* fix(structure): correcting using types in tanstack type def

* feat(structure): fixing styling for input cell field

* test(structure): testing for read only

* test(structure): testing for different text types

* test(structure): testing for boolean cells

* feat(structure): supporting unset across all sheet fields

* feat(structure): testing for radio selects

* feat(structure): testing when deleting on dropdown

* refactor(structure): lifting up read only operation blocking to list pane

* fix(structure): adding CellValidation back to SheetListCell

* feat(structure): add support for sheet list inputs (#6912)

* feat(structure): add sheet list publish action
pending items:
- validate user permissions for publish
- validate document

* feat(structure): add publish action popover and validation to documents rows

* fix(structure): update sheet list select column

* feat(structure): edx-1313 - clicking on a row opens the document

* fix(structure): move preview to it's own file, fix title

* fix(structure): refactor paneItemPreview to create it's own title

* add selected state to rows

* fix(structure): sheet list headers reduce height

* feat(structure): add column resizing to sheet list table EDX-1452

* fix(structure): update how selected rows border is generated

* fix(structure): when hiding parent column, hide all children

* fix(structure): ui update to sheet list table actions

* feat(structure): sheet list view patching (#6866)

* feat(structure): escape cancels changes to value

* feat(structure): add sheet list publish action
pending items:
- validate user permissions for publish
- validate document

* feat(structure): add publish action popover and validation to documents rows

* fix(structure): update sheet list select column

* feat(structure): edx-1313 - clicking on a row opens the document

* fix(structure): move preview to it's own file, fix title

* fix(structure): refactor paneItemPreview to create it's own title

* add selected state to rows

* fix(structure): sheet list headers reduce height

* feat(structure): add column resizing to sheet list table EDX-1452

* fix(structure): update how selected rows border is generated

* fix(structure): when hiding parent column, hide all children

* fix(structure): ui update to sheet list table actions

* feat(structure): sheet list view patching (#6866)

* chore(structure): update exports and remove unnecesary imports, fix build issues

* feat(structure): delete key deletes values

* feat(structure): reverting unintended import change

* fix(structure): memoize items ids value in documentSheetActions

* fix(structure): update how actions popover width is calculated, use matchReferenceWidth

* fix(structure): add tests for nested header hiding action

* fix(structure): update previewTitle fallback in paneItemPreview

* feat(structure): add unset document value into sheetlist

* feat(structure): select and focus styling for cells

* feat(structure): removing unused method for border styles

* refactor(structure): removing sheetCellInner and moving to SheetCell

* refactor(structure): reusing existing primitive type assertion

* feat(structure): parsing field values to field types

* feat(structure): parsing field values to field types

* fix(structure): fixing issue where real time updates only happened if value already existed

* feat(structure): number inputs allow for default behavior

* fix(structure): update selected sheets styles, add disableCellFocus property

* refactor(structure); fixing failing sheet list pane tests

* feat(structure): sheet list delete and cancel cell edits (#6890)

* feat(structure): escape cancels changes to value

* feat(structure): delete key deletes values

* feat(structure): add unset document value into sheetlist

---------

Co-authored-by: Pedro Bonamin <pedrobonamin@gmail.com>

* feat(structure): add support for boolean inputs (#6898)

* feat(structure): add support for boolean inputs

* chore(deps): dedupe pnpm-lock.yaml (#6916)

Co-authored-by: juice49 <1454914+juice49@users.noreply.github.com>

* chore(deps): update dependency @sanity/tsdoc to v1.0.72 (#6911)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(deps): upgrade react-rx to v3 (#6883)

Co-authored-by: Bjørge Næss <876086+bjoerge@users.noreply.github.com>

* fix(deps): Update dev-non-major (#6915)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(structure): using upgraded react-rx

* Sheet dropdown (#6955)

* refactor(structure): fixing issue with react-compiler and mutated reference

* refactor(structure): passing ref to cellInput

* feat(structure): supporting string and number dropdowns

* fix(structure): fixing issue where copy on focused cells wasn't happening

* fix(structure): resolving unsetting issues with sheet list inputs

* feat(structure): radio selects don't allow unset value

* fix(structure): use ref for all sheet cells for focusing

* fix(structure): correcting using types in tanstack type def

* feat(structure): translations for sheet list (#6972)

* feat(structure): translations for sheet list actions

* feat(structure): translations for sheet list

* feat(structure): creating separate namespace for sheet list locale

* feat(structure): add validation to sheet list cell (#6933)

* feat(structure): add validation to sheet list cell

* feat(structure): show validation icon only on cell hover

* fix(structure): update sheet list validation level function

Co-authored-by: Jordan Lawrence <jordanl17@me.com>

* chore(structure): remove comment

---------

Co-authored-by: Jordan Lawrence <jordanl17@me.com>

* chore(structure): disable sheet list view if no schemaType is found

* feat(structure): read only sheet (#6954)

* refactor(structure): fixing issue with react-compiler and mutated reference

* refactor(structure): passing ref to cellInput

* feat(structure): supporting string and number dropdowns

* fix(structure): fixing issue where copy on focused cells wasn't happening

* fix(structure): resolving unsetting issues with sheet list inputs

* feat(structure): radio selects don't allow unset value

* fix(structure): use ref for all sheet cells for focusing

* fix(structure): correcting using types in tanstack type def

* feat(structure): supporting read only inputs in sheet list

* Sheet dropdown (#6955)

* refactor(structure): fixing issue with react-compiler and mutated reference

* refactor(structure): passing ref to cellInput

* feat(structure): supporting string and number dropdowns

* fix(structure): fixing issue where copy on focused cells wasn't happening

* fix(structure): resolving unsetting issues with sheet list inputs

* feat(structure): radio selects don't allow unset value

* fix(structure): use ref for all sheet cells for focusing

* fix(structure): correcting using types in tanstack type def

* feat(structure): fixing styling for input cell field

* test(structure): testing for read only

* test(structure): testing for different text types

* test(structure): testing for boolean cells

* feat(structure): supporting unset across all sheet fields

* feat(structure): testing for radio selects

* feat(structure): testing when deleting on dropdown

* refactor(structure): lifting up read only operation blocking to list pane

* fix(structure): adding CellValidation back to SheetListCell

* fix(structure): update tests and remove unnecessary file

---------

Co-authored-by: jordanl17 <jordanl17@me.com>
Co-authored-by: ecospark[bot] <128108030+ecospark[bot]@users.noreply.github.com>
Co-authored-by: juice49 <1454914+juice49@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Cody Olsen <81981+stipsan@users.noreply.github.com>
Co-authored-by: Bjørge Næss <876086+bjoerge@users.noreply.github.com>

* refactor(structure): removing unnecessary line break

* refactor(structure): fixing missing generalised type for DocumentSheetListPane ops; fixing duplicated test line

* refactor(structure): fixing missing generalised type for DocumentSheetListPane ops

* refactor(structure): moved order settings to useDocumentSheetList

* refactor(structure): tidying the naming

* feat(structure): testing sorting on sheet list order

* fix(structure): resolving issue with key where list would not rerender when new selection made

* refactor(structure): PR comments to pass typename to useDocumentListSort

---------

Co-authored-by: Pedro Bonamin <pedrobonamin@gmail.com>
Co-authored-by: Pedro Bonamin <46196328+pedrobonamin@users.noreply.github.com>
Co-authored-by: ecospark[bot] <128108030+ecospark[bot]@users.noreply.github.com>
Co-authored-by: juice49 <1454914+juice49@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Cody Olsen <81981+stipsan@users.noreply.github.com>
Co-authored-by: Bjørge Næss <876086+bjoerge@users.noreply.github.com>
Co-authored-by: Binoy Patel <me@binoy.io>
Co-authored-by: Christian Grøngaard <christian.groengaard@sanity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants