chore(page-building): clean up schema types #6973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Jun 18, 2024 1:43 PM (UTC)
|
rexxars
approved these changes
Jun 25, 2024
ricokahler
pushed a commit
that referenced
this pull request
Jun 26, 2024
jordanl17
added a commit
that referenced
this pull request
Jul 3, 2024
* feat(structure): add sheet list publish action pending items: - validate user permissions for publish - validate document * feat(structure): add publish action popover and validation to documents rows * fix(structure): update sheet list select column * feat(structure): edx-1313 - clicking on a row opens the document * fix(structure): move preview to it's own file, fix title * fix(structure): refactor paneItemPreview to create it's own title * add selected state to rows * fix(structure): sheet list headers reduce height * feat(structure): add column resizing to sheet list table EDX-1452 * fix(structure): update how selected rows border is generated * fix(structure): when hiding parent column, hide all children * fix(structure): ui update to sheet list table actions * feat(structure): sheet list view patching (#6866) * feat(structure): escape cancels changes to value * feat(structure): add sheet list publish action pending items: - validate user permissions for publish - validate document * feat(structure): add publish action popover and validation to documents rows * fix(structure): update sheet list select column * feat(structure): edx-1313 - clicking on a row opens the document * fix(structure): move preview to it's own file, fix title * fix(structure): refactor paneItemPreview to create it's own title * add selected state to rows * fix(structure): sheet list headers reduce height * feat(structure): add column resizing to sheet list table EDX-1452 * fix(structure): update how selected rows border is generated * fix(structure): when hiding parent column, hide all children * fix(structure): ui update to sheet list table actions * feat(structure): sheet list view patching (#6866) * chore(structure): update exports and remove unnecesary imports, fix build issues * feat(structure): delete key deletes values * feat(structure): reverting unintended import change * fix(structure): memoize items ids value in documentSheetActions * fix(structure): update how actions popover width is calculated, use matchReferenceWidth * fix(structure): add tests for nested header hiding action * fix(structure): update previewTitle fallback in paneItemPreview * feat(structure): add unset document value into sheetlist * feat(structure): select and focus styling for cells * feat(structure): removing unused method for border styles * refactor(structure): removing sheetCellInner and moving to SheetCell * refactor(structure): reusing existing primitive type assertion * feat(structure): parsing field values to field types * feat(structure): parsing field values to field types * fix(structure): fixing issue where real time updates only happened if value already existed * feat(structure): number inputs allow for default behavior * fix(structure): update selected sheets styles, add disableCellFocus property * refactor(structure); fixing failing sheet list pane tests * feat(structure): sheet list delete and cancel cell edits (#6890) * feat(structure): escape cancels changes to value * feat(structure): delete key deletes values * feat(structure): add unset document value into sheetlist --------- Co-authored-by: Pedro Bonamin <pedrobonamin@gmail.com> * feat(structure): add support for boolean inputs (#6898) * feat(structure): add support for boolean inputs * chore(deps): dedupe pnpm-lock.yaml (#6916) Co-authored-by: juice49 <1454914+juice49@users.noreply.github.com> * chore(deps): update dependency @sanity/tsdoc to v1.0.72 (#6911) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(deps): upgrade react-rx to v3 (#6883) Co-authored-by: Bjørge Næss <876086+bjoerge@users.noreply.github.com> * fix(deps): Update dev-non-major (#6915) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(structure): using upgraded react-rx * Sheet dropdown (#6955) * refactor(structure): fixing issue with react-compiler and mutated reference * refactor(structure): passing ref to cellInput * feat(structure): supporting string and number dropdowns * fix(structure): fixing issue where copy on focused cells wasn't happening * fix(structure): resolving unsetting issues with sheet list inputs * feat(structure): radio selects don't allow unset value * fix(structure): use ref for all sheet cells for focusing * fix(structure): correcting using types in tanstack type def * feat(structure): sorting sheet list using search order * feat(structure): fixing sheet list loading state * feat(structure): fixing test to use sort order * feat(structure): reverting skipped test * feat(structure): refactor to reuse in sheet list and list * feat(structure): translations for sheet list (#6972) * feat(structure): translations for sheet list actions * feat(structure): translations for sheet list * feat(structure): creating separate namespace for sheet list locale * fix(core): update url for notify endpoint (#7022) * chore(page-building): clean up schema types (#6973) * feat(structure): add validation to sheet list cell (#6933) * feat(structure): add validation to sheet list cell * feat(structure): show validation icon only on cell hover * fix(structure): update sheet list validation level function Co-authored-by: Jordan Lawrence <jordanl17@me.com> * chore(structure): remove comment --------- Co-authored-by: Jordan Lawrence <jordanl17@me.com> * chore(structure): disable sheet list view if no schemaType is found * feat(structure): add sheet list publish action pending items: - validate user permissions for publish - validate document * feat(structure): add publish action popover and validation to documents rows * fix(structure): update sheet list select column * feat(structure): edx-1313 - clicking on a row opens the document * fix(structure): move preview to it's own file, fix title * fix(structure): refactor paneItemPreview to create it's own title * add selected state to rows * fix(structure): sheet list headers reduce height * feat(structure): add column resizing to sheet list table EDX-1452 * fix(structure): update how selected rows border is generated * fix(structure): when hiding parent column, hide all children * fix(structure): ui update to sheet list table actions * feat(structure): sheet list view patching (#6866) * chore(structure): update exports and remove unnecesary imports, fix build issues * fix(structure): memoize items ids value in documentSheetActions * fix(structure): update how actions popover width is calculated, use matchReferenceWidth * fix(structure): add tests for nested header hiding action * fix(structure): update previewTitle fallback in paneItemPreview * feat(structure): sheet list delete and cancel cell edits (#6890) * feat(structure): escape cancels changes to value * feat(structure): delete key deletes values * feat(structure): add unset document value into sheetlist --------- Co-authored-by: Pedro Bonamin <pedrobonamin@gmail.com> * fix(structure): when documents are added, add them to sheet list (#6944) * fix(structure): when documents are added, add them to the sheet list data * fix(structure): update paneContainer test * feat(structure): read only sheet (#6954) * refactor(structure): fixing issue with react-compiler and mutated reference * refactor(structure): passing ref to cellInput * feat(structure): supporting string and number dropdowns * fix(structure): fixing issue where copy on focused cells wasn't happening * fix(structure): resolving unsetting issues with sheet list inputs * feat(structure): radio selects don't allow unset value * fix(structure): use ref for all sheet cells for focusing * fix(structure): correcting using types in tanstack type def * feat(structure): supporting read only inputs in sheet list * Sheet dropdown (#6955) * refactor(structure): fixing issue with react-compiler and mutated reference * refactor(structure): passing ref to cellInput * feat(structure): supporting string and number dropdowns * fix(structure): fixing issue where copy on focused cells wasn't happening * fix(structure): resolving unsetting issues with sheet list inputs * feat(structure): radio selects don't allow unset value * fix(structure): use ref for all sheet cells for focusing * fix(structure): correcting using types in tanstack type def * feat(structure): fixing styling for input cell field * test(structure): testing for read only * test(structure): testing for different text types * test(structure): testing for boolean cells * feat(structure): supporting unset across all sheet fields * feat(structure): testing for radio selects * feat(structure): testing when deleting on dropdown * refactor(structure): lifting up read only operation blocking to list pane * fix(structure): adding CellValidation back to SheetListCell * feat(structure): add support for sheet list inputs (#6912) * feat(structure): add sheet list publish action pending items: - validate user permissions for publish - validate document * feat(structure): add publish action popover and validation to documents rows * fix(structure): update sheet list select column * feat(structure): edx-1313 - clicking on a row opens the document * fix(structure): move preview to it's own file, fix title * fix(structure): refactor paneItemPreview to create it's own title * add selected state to rows * fix(structure): sheet list headers reduce height * feat(structure): add column resizing to sheet list table EDX-1452 * fix(structure): update how selected rows border is generated * fix(structure): when hiding parent column, hide all children * fix(structure): ui update to sheet list table actions * feat(structure): sheet list view patching (#6866) * feat(structure): escape cancels changes to value * feat(structure): add sheet list publish action pending items: - validate user permissions for publish - validate document * feat(structure): add publish action popover and validation to documents rows * fix(structure): update sheet list select column * feat(structure): edx-1313 - clicking on a row opens the document * fix(structure): move preview to it's own file, fix title * fix(structure): refactor paneItemPreview to create it's own title * add selected state to rows * fix(structure): sheet list headers reduce height * feat(structure): add column resizing to sheet list table EDX-1452 * fix(structure): update how selected rows border is generated * fix(structure): when hiding parent column, hide all children * fix(structure): ui update to sheet list table actions * feat(structure): sheet list view patching (#6866) * chore(structure): update exports and remove unnecesary imports, fix build issues * feat(structure): delete key deletes values * feat(structure): reverting unintended import change * fix(structure): memoize items ids value in documentSheetActions * fix(structure): update how actions popover width is calculated, use matchReferenceWidth * fix(structure): add tests for nested header hiding action * fix(structure): update previewTitle fallback in paneItemPreview * feat(structure): add unset document value into sheetlist * feat(structure): select and focus styling for cells * feat(structure): removing unused method for border styles * refactor(structure): removing sheetCellInner and moving to SheetCell * refactor(structure): reusing existing primitive type assertion * feat(structure): parsing field values to field types * feat(structure): parsing field values to field types * fix(structure): fixing issue where real time updates only happened if value already existed * feat(structure): number inputs allow for default behavior * fix(structure): update selected sheets styles, add disableCellFocus property * refactor(structure); fixing failing sheet list pane tests * feat(structure): sheet list delete and cancel cell edits (#6890) * feat(structure): escape cancels changes to value * feat(structure): delete key deletes values * feat(structure): add unset document value into sheetlist --------- Co-authored-by: Pedro Bonamin <pedrobonamin@gmail.com> * feat(structure): add support for boolean inputs (#6898) * feat(structure): add support for boolean inputs * chore(deps): dedupe pnpm-lock.yaml (#6916) Co-authored-by: juice49 <1454914+juice49@users.noreply.github.com> * chore(deps): update dependency @sanity/tsdoc to v1.0.72 (#6911) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(deps): upgrade react-rx to v3 (#6883) Co-authored-by: Bjørge Næss <876086+bjoerge@users.noreply.github.com> * fix(deps): Update dev-non-major (#6915) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(structure): using upgraded react-rx * Sheet dropdown (#6955) * refactor(structure): fixing issue with react-compiler and mutated reference * refactor(structure): passing ref to cellInput * feat(structure): supporting string and number dropdowns * fix(structure): fixing issue where copy on focused cells wasn't happening * fix(structure): resolving unsetting issues with sheet list inputs * feat(structure): radio selects don't allow unset value * fix(structure): use ref for all sheet cells for focusing * fix(structure): correcting using types in tanstack type def * feat(structure): translations for sheet list (#6972) * feat(structure): translations for sheet list actions * feat(structure): translations for sheet list * feat(structure): creating separate namespace for sheet list locale * feat(structure): add validation to sheet list cell (#6933) * feat(structure): add validation to sheet list cell * feat(structure): show validation icon only on cell hover * fix(structure): update sheet list validation level function Co-authored-by: Jordan Lawrence <jordanl17@me.com> * chore(structure): remove comment --------- Co-authored-by: Jordan Lawrence <jordanl17@me.com> * chore(structure): disable sheet list view if no schemaType is found * feat(structure): read only sheet (#6954) * refactor(structure): fixing issue with react-compiler and mutated reference * refactor(structure): passing ref to cellInput * feat(structure): supporting string and number dropdowns * fix(structure): fixing issue where copy on focused cells wasn't happening * fix(structure): resolving unsetting issues with sheet list inputs * feat(structure): radio selects don't allow unset value * fix(structure): use ref for all sheet cells for focusing * fix(structure): correcting using types in tanstack type def * feat(structure): supporting read only inputs in sheet list * Sheet dropdown (#6955) * refactor(structure): fixing issue with react-compiler and mutated reference * refactor(structure): passing ref to cellInput * feat(structure): supporting string and number dropdowns * fix(structure): fixing issue where copy on focused cells wasn't happening * fix(structure): resolving unsetting issues with sheet list inputs * feat(structure): radio selects don't allow unset value * fix(structure): use ref for all sheet cells for focusing * fix(structure): correcting using types in tanstack type def * feat(structure): fixing styling for input cell field * test(structure): testing for read only * test(structure): testing for different text types * test(structure): testing for boolean cells * feat(structure): supporting unset across all sheet fields * feat(structure): testing for radio selects * feat(structure): testing when deleting on dropdown * refactor(structure): lifting up read only operation blocking to list pane * fix(structure): adding CellValidation back to SheetListCell * fix(structure): update tests and remove unnecessary file --------- Co-authored-by: jordanl17 <jordanl17@me.com> Co-authored-by: ecospark[bot] <128108030+ecospark[bot]@users.noreply.github.com> Co-authored-by: juice49 <1454914+juice49@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Cody Olsen <81981+stipsan@users.noreply.github.com> Co-authored-by: Bjørge Næss <876086+bjoerge@users.noreply.github.com> * refactor(structure): removing unnecessary line break * refactor(structure): fixing missing generalised type for DocumentSheetListPane ops; fixing duplicated test line * refactor(structure): fixing missing generalised type for DocumentSheetListPane ops * refactor(structure): moved order settings to useDocumentSheetList * refactor(structure): tidying the naming * feat(structure): testing sorting on sheet list order * fix(structure): resolving issue with key where list would not rerender when new selection made * refactor(structure): PR comments to pass typename to useDocumentListSort --------- Co-authored-by: Pedro Bonamin <pedrobonamin@gmail.com> Co-authored-by: Pedro Bonamin <46196328+pedrobonamin@users.noreply.github.com> Co-authored-by: ecospark[bot] <128108030+ecospark[bot]@users.noreply.github.com> Co-authored-by: juice49 <1454914+juice49@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Cody Olsen <81981+stipsan@users.noreply.github.com> Co-authored-by: Bjørge Næss <876086+bjoerge@users.noreply.github.com> Co-authored-by: Binoy Patel <me@binoy.io> Co-authored-by: Christian Grøngaard <christian.groengaard@sanity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.