feat: add canvas as a source for useQuery and useDispatchIntent #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cngonzalez
requested review from
colepeters and
laurenashpole
and removed request for
binoy14
laurenashpole
requested changes
Nov 12, 2025
Contributor
laurenashpole
left a comment
laurenashpole
left a comment
There was a problem hiding this comment.
Looking good! I left a couple comments about document type names and the type changes we talked about at pairing (unfortunately I couldn't leave that as a suggestion).
packages/react/src/hooks/dashboard/utils/getResourceIdFromDocumentHandle.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Lauren Ashpole <lauren@laurenashpole.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
canvasSourcewhich behaves likemediaLibrarySource. Right now, thesourceparam is only respected byuseQueryanduseDispatchIntent. Minimal logic was added touseDispatchIntentto ensure that it can dispatch intents for Canvas documents, and corresponding Kitchensink components were added to this as well.I also corrected the resource type for the
media-libraryresource type, since that's the string used basically everywhere. It doesn't change functionality, since intents don't care about resource types (only document types).What to review
Again, please keep me honest and make sure things are appropriately marked
beta!Testing
A few tests were added to ensure 100% coverage of all logic branches. Also, Kitchensink was deployed with these changes: https://core-4owxlg8l9.sanity.build/@oblZgbTFj/application/wkyoigmzawwnnwx458zgoh46/intents
If buttons don't work, try to navigate to another app and back to the Kitchensink (it's a bug I'm working on).
Fun gif