Check for active object before switching to object mode #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
saturday06
force-pushed
the
next
branch
3 times, most recently
from
b74dd7e to
36fb2c2
Compare
|
Thank you very much ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the exporter iterates through each mesh to export, it needs to enter edit mode to work with the mesh data.
Before this must happen, we must enter object mode so we can pick the mesh we want to use.
However, in some cases, there will be no mesh selected - causing mode_set() to fail, as there is no active object, causing a crash.
This fixes this crash by just not bothering to switch into object mode if nothing is selected, as it's a redundant operation at that point.
Additionally, blender safeguards against misbehavior here - if you try to deselect
bpy.context.view_layer.objects.activeby setting it to none while in any mode other than object mode, it kicks you back into object mode, allowing you to select a new mesh.Fixes #70