Error parsing when using default configuration

[travs]

When I run ./node_modules/.bin/solidity-coverage after installing in my project, I get the following error.

Launching testrpc on port 8555
Launching test command (this can take a few seconds)...
Using network 'development'.

SyntaxError: Error parsing /home/travis/prg/protocol/coverageEnv/contracts/governance/GovernanceProtocol.sol: Expected "contract", "import", "library", "pragma", "using", comment, end of input, end of line, or whitespace but "e" found. Line: 6, Column: 31
    at peg$buildStructuredError (/usr/local/lib/node_modules/truffle/node_modules/solidity-parser/build/imports_parser.js:543:12)
    at Object.peg$parse [as parse] (/usr/local/lib/node_modules/truffle/node_modules/solidity-parser/build/imports_parser.js:4142:11)
    at Object.parse (/usr/local/lib/node_modules/truffle/node_modules/solidity-parser/index.js:34:23)
    at /usr/local/lib/node_modules/truffle/node_modules/truffle-compile/profiler.js:200:36
    at /usr/local/lib/node_modules/truffle/node_modules/truffle-resolver/index.js:79:5
    at /usr/local/lib/node_modules/truffle/node_modules/truffle-resolver/node_modules/async/internal/onlyOnce.js:12:16
    at next (/usr/local/lib/node_modules/truffle/node_modules/truffle-resolver/node_modules/async/whilst.js:68:18)
    at /usr/local/lib/node_modules/truffle/node_modules/truffle-resolver/index.js:64:7
    at /usr/local/lib/node_modules/truffle/node_modules/truffle-resolver/fs.js:65:5
    at /usr/local/lib/node_modules/truffle/node_modules/truffle-resolver/node_modules/async/internal/once.js:12:16
Cleaning up...

    There was an error generating coverage. Possible reasons include:
    1. Another application is using port 8555
    2. Truffle crashed because your tests errored

  Error: ENOENT: no such file or directory, open './allFiredEvents'
Exiting without generating coverage...

May be worth nothing that there is no configuration stub generated in my truffle.json after this error, which should be there if I understand the readme correctly.

This is almost definitely something wrong on my end though, since it looks like you guys got it to work on the melonport protocol just fine, which is the code that I'm currently trying the coverage tool on.

[cgewecke]

Hi @travs I think it's actually a solidity-parser error that caused by the contracts that are like this:

contract RedeemProtocol {}

I just stuck a nonsense statement in the contract to hack around it: bool x = true; May also work if you put the closing bracket on the following line - i.e add some whitespace? That needs a fix over in SP though. . .

[travs]

@cgewecke
Thank you for the ultra-quick reply!

Hmm ok, I think you're right about the source being solidity-parser, but I'm unable to replicate this by just doing ./node_modules/.bin/solidity-parser ./contracts/governance/GovernanceProtocol.sol, or even ./node_modules/solidity-coverage/node_modules/.bin/solidity-parser ./contracts/governance/GovernanceProtocol.sol (not sure if they're different).

Once I can replicate I will open an issue in that repo.

[cgewecke]

Hmm interesting. We use a fork so it's the parser in /solidity-coverage - actually I'll fix our fork tonight, sorry. That's the easiest thing to do.

The commit that successfully generated the report is here @ sc-forks/protocol.

I also see that we made a .solcover.js config file and are accessing the local version of truffle that you have as a dep. The path to it is weird because coverage execution context is inside a folder that copies the target project.

[travs]

@cgewecke
Ok, thank you again for tackling this with such speed.

Thanks for the tip about the config file; looking forward to your update :)

[cgewecke]

@travs You were right about it parsing fine . . . this was a bug in our instrumentation logic. It's fixed and published with 0.1.7. Also checked it against the sc-forks/protocol branch (hacky stuff removed) and it seems to work ok. There's a long pause after the compilation step but eventually it runs. Updated the linked-to report, which looks good! Very green!

Thanks for opening.

[cgewecke]

Also let me know if you run into any more difficulties - the fork I tested against is a few weeks old.

[travs]

Ok, pulled the 0.1.7 release and now running into this error:

Launching testrpc on port 8555
Launching test command (this can take a few seconds)...
Error: Invalid JSON RPC response: ""
    at Object.InvalidResponse (/home/travis/prg/protocol/node_modules/truffle-provider/node_modules/web3/lib/web3/errors.js:35:16)
    at XMLHttpRequest.request.onreadystatechange (/home/travis/prg/protocol/node_modules/truffle-provider/node_modules/web3/lib/web3/httpprovider.js:115:32)
    at XMLHttpRequestEventTarget.dispatchEvent (/home/travis/prg/protocol/node_modules/xhr2/lib/xhr2.js:64:18)
    at XMLHttpRequest._setReadyState (/home/travis/prg/protocol/node_modules/xhr2/lib/xhr2.js:354:12)
    at XMLHttpRequest._onHttpRequestError (/home/travis/prg/protocol/node_modules/xhr2/lib/xhr2.js:544:12)
    at ClientRequest.<anonymous> (/home/travis/prg/protocol/node_modules/xhr2/lib/xhr2.js:414:24)
    at emitOne (events.js:115:13)
    at ClientRequest.emit (events.js:210:7)
    at Socket.socketErrorListener (_http_client.js:400:9)
    at emitOne (events.js:115:13)
Cleaning up...

I have the .solium.js file present as in your fork.
And nothing is running on 8555 (checked with ps -fp 8555 and lsof -f :8555.

Am I missing a step somewhere?

My testrpc versions as per npm list |grep rpc

├── ethereumjs-testrpc@3.9.2
│ ├─┬ ethereumjs-testrpc-sc@3.0.3 (git+https://github.com/sc-forks/testrpc-sc.git#15cc0fb8e031bee152c7b8e3f8df5f2ad33ca04f)

Will test on your fork in a few moments and confirm that this is local to me, and not the project.

Update: Alright so it actually works on your fork, but not on the current master branch. Curious 😕

[travs]

Update 2: Re-cloned our latest branch with a passing build (participation) and it runs the tests now, but fails just after the tests with a different error:

Cleaning up...

    There was an error generating coverage. Possible reasons include:
    1. Another application is using port 8555
    2. Truffle crashed because your tests errored

  Error: ENOENT: no such file or directory, open './allFiredEvents'
Exiting without generating coverage...

The master branch has build errors, so in all future attempts I will use the current participation branch

[cgewecke]

Ok cool, I'll check it out this afternoon.