Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Float range and Double range #10781

Closed
eed3si9n opened this issue Mar 15, 2018 · 7 comments · Fixed by scala/scala#6468
Closed

Remove Float range and Double range #10781

eed3si9n opened this issue Mar 15, 2018 · 7 comments · Fixed by scala/scala#6468
Assignees
@eed3si9n
Labels
library:collections library
Milestone
2.13.0-M5

Comments

@eed3si9n
Copy link
Member

Ref scala/collection-strawman#489
Ref #8518
Ref #9875
Ref #9874
Ref #8620
Ref #8670

I tried to fix the Double range issue in scala/collection-strawman#489, but ultimately I was not able to overcome the fact that addition in IEEE float doesn't behave in the way we need ranges to behave.

During the review @Ichoran suggested that we remove floating point ranges:

Normally I don't like breaking changes, but in the case where there is no way to do the right thing except by not actually using the type that is stated, I think the better thing to do is remove the feature.

After thinking about it, I agree that it's the right thing to do since it doesn't work. If people want decimal ranges, BigDecimal range would behave in predictable way.
@eed3si9n eed3si9n mentioned this issue Mar 15, 2018
Closed
@NthPortal
Copy link

also #10759

@NthPortal
Copy link

What should 1.0 to 5.0 do, if Double ranges are removed? Should it not exist, or should it just return a BigDecimal range?

@ritschwumm
Copy link

not exist, of course, everything else would be a bit surprising

eed3si9n added a commit to eed3si9n/scala that referenced this issue Mar 25, 2018
@eed3si9n
Remove Float range and Double range
9e27fa3 
Fixes scala/bug#10781

At the basis of range is an assumption that summation works reliably. Unfortunately it is not true for IEEE floating point number where numbers are stored as approximate fraction of binary numbers. Natually, Double and Float ranges are completely broken. See numbers of issues such as scala/bug#8518, scala/bug#9875, scala/bug#9874, scala/bug#8620, scala/bug#8670, and scala/bug#10759.

I've attempted to fix the Double range in scala/collection-strawman#489 by faking it further using BigDecimal, but ultimately I was not able to overcome the fact that IEEE floats are not suited for ranges.

This removes both Float and Double ranges, as well as the fake `Integral[T]` instances that underpins the ranges.
eed3si9n added a commit to eed3si9n/scala that referenced this issue Mar 25, 2018
@eed3si9n
Remove Float range and Double range
d839c74 
Fixes scala/bug#10781

At the basis of range is an assumption that summation works reliably. Unfortunately it is not true for IEEE floating point number where numbers are stored as approximate fraction of binary numbers. Natually, Double and Float ranges are completely broken. See numbers of issues such as scala/bug#8518, scala/bug#9875, scala/bug#9874, scala/bug#8620, scala/bug#8670, and scala/bug#10759.

I've attempted to fix the Double range in scala/collection-strawman#489 by faking it further using BigDecimal, but ultimately I was not able to overcome the fact that IEEE floats are not suited for ranges.

This removes both Float and Double ranges, as well as the fake `Integral[T]` instances that underpin their existence.
@eed3si9n eed3si9n mentioned this issue Mar 25, 2018
Merged
@eed3si9n eed3si9n self-assigned this Mar 25, 2018
@eed3si9n
Copy link
Member Author

Sent a PR on this scala/scala#6468

@eed3si9n
Copy link
Member Author

What should 1.0 to 5.0 do, if Double ranges are removed?

to is a sugar, so it should not compile.

eed3si9n added a commit to eed3si9n/scala that referenced this issue Mar 31, 2018
@eed3si9n
Remove Float range and Double range
c883a7f 
Fixes scala/bug#10781

At the basis of range is an assumption that summation works reliably. Unfortunately it is not true for IEEE floating point number where numbers are stored as approximate fraction of binary numbers. Natually, Double and Float ranges are completely broken. See numbers of issues such as scala/bug#8518, scala/bug#9875, scala/bug#9874, scala/bug#8620, scala/bug#8670, and scala/bug#10759.

I've attempted to fix the Double range in scala/collection-strawman#489 by faking it further using BigDecimal, but ultimately I was not able to overcome the fact that IEEE floats are not suited for ranges.

This removes both Float and Double ranges, as well as the fake `Integral[T]` instances that underpin their existence.
eed3si9n added a commit to eed3si9n/scala that referenced this issue Apr 5, 2018
@eed3si9n
Remove Float range and Double range
ca35ada 
Fixes scala/bug#10781

At the basis of range is an assumption that summation works reliably. Unfortunately it is not true for IEEE floating point number where numbers are stored as approximate fraction of binary numbers. Natually, Double and Float ranges are completely broken. See numbers of issues such as scala/bug#8518, scala/bug#9875, scala/bug#9874, scala/bug#8620, scala/bug#8670, and scala/bug#10759.

I've attempted to fix the Double range in scala/collection-strawman#489 by faking it further using BigDecimal, but ultimately I was not able to overcome the fact that IEEE floats are not suited for ranges.

This removes both Float and Double ranges, as well as the fake `Integral[T]` instances that underpin their existence.
eed3si9n added a commit to eed3si9n/scala that referenced this issue Apr 12, 2018
@eed3si9n
Remove Float range and Double range
1f0f608 
Fixes scala/bug#10781

At the basis of range is an assumption that summation works reliably. Unfortunately it is not true for IEEE floating point number where numbers are stored as approximate fraction of binary numbers. Natually, Double and Float ranges are completely broken. See numbers of issues such as scala/bug#8518, scala/bug#9875, scala/bug#9874, scala/bug#8620, scala/bug#8670, and scala/bug#10759.

I've attempted to fix the Double range in scala/collection-strawman#489 by faking it further using BigDecimal, but ultimately I was not able to overcome the fact that IEEE floats are not suited for ranges.

This removes both Float and Double ranges, as well as the fake `Integral[T]` instances that underpin their existence.
eed3si9n added a commit to eed3si9n/scala that referenced this issue Apr 12, 2018
@eed3si9n
Remove Float range and Double range
485b2b2 
Fixes scala/bug#10781

At the basis of range is an assumption that summation works reliably. Unfortunately it is not true for IEEE floating point number where numbers are stored as approximate fraction of binary numbers. Natually, Double and Float ranges are completely broken. See numbers of issues such as scala/bug#8518, scala/bug#9875, scala/bug#9874, scala/bug#8620, scala/bug#8670, and scala/bug#10759.

I've attempted to fix the Double range in scala/collection-strawman#489 by faking it further using BigDecimal, but ultimately I was not able to overcome the fact that IEEE floats are not suited for ranges.

This removes both Float and Double ranges, as well as the fake `Integral[T]` instances that underpin their existence.
eed3si9n added a commit to eed3si9n/scala that referenced this issue Apr 12, 2018
@eed3si9n
Remove Float range and Double range
e41fae8 
Fixes scala/bug#10781

At the basis of range is an assumption that summation works reliably. Unfortunately it is not true for IEEE floating point number where numbers are stored as approximate fraction of binary numbers. Natually, Double and Float ranges are completely broken. See numbers of issues such as scala/bug#8518, scala/bug#9875, scala/bug#9874, scala/bug#8620, scala/bug#8670, and scala/bug#10759.

I've attempted to fix the Double range in scala/collection-strawman#489 by faking it further using BigDecimal, but ultimately I was not able to overcome the fact that IEEE floats are not suited for ranges.

This removes both Float and Double ranges, as well as the fake `Integral[T]` instances that underpin their existence.
eed3si9n added a commit to eed3si9n/scala that referenced this issue Apr 23, 2018
@eed3si9n
Deprecate Float range and Double range
4d509e6 
Ref scala/bug#10781

This is in prepration of Float range and Double range removal in 2.13.x (scala#6468).
eed3si9n added a commit to eed3si9n/scala that referenced this issue Apr 23, 2018
@eed3si9n
Deprecate Float range and Double range
340b899 
Ref scala/bug#10781

This is in preparation for Float range and Double range removal in 2.13.x (scala#6468).
@eed3si9n eed3si9n mentioned this issue Apr 23, 2018
Merged
eed3si9n added a commit to eed3si9n/scala that referenced this issue Apr 26, 2018
@eed3si9n
Remove Float range and Double range
feca33c 
Fixes scala/bug#10781

At the basis of range is an assumption that summation works reliably. Unfortunately it is not true for IEEE floating point number where numbers are stored as approximate fraction of binary numbers. Natually, Double and Float ranges are completely broken. See numbers of issues such as scala/bug#8518, scala/bug#9875, scala/bug#9874, scala/bug#8620, scala/bug#8670, and scala/bug#10759.

I've attempted to fix the Double range in scala/collection-strawman#489 by faking it further using BigDecimal, but ultimately I was not able to overcome the fact that IEEE floats are not suited for ranges.

This removes both Float and Double ranges, as well as the fake `Integral[T]` instances that underpin their existence.
eed3si9n added a commit to eed3si9n/scala that referenced this issue May 4, 2018
@eed3si9n
Remove Float range and Double range
7db5bcc 
Fixes scala/bug#10781

At the basis of range is an assumption that summation works reliably. Unfortunately it is not true for IEEE floating point number where numbers are stored as approximate fraction of binary numbers. Natually, Double and Float ranges are completely broken. See numbers of issues such as scala/bug#8518, scala/bug#9875, scala/bug#9874, scala/bug#8620, scala/bug#8670, and scala/bug#10759.

I've attempted to fix the Double range in scala/collection-strawman#489 by faking it further using BigDecimal, but ultimately I was not able to overcome the fact that IEEE floats are not suited for ranges.

This removes both Float and Double ranges, as well as the fake `Integral[T]` instances that underpin their existence.
eed3si9n added a commit to eed3si9n/scala that referenced this issue May 4, 2018
@eed3si9n
Remove Float range and Double range
16f58a1 
Fixes scala/bug#10781

At the basis of range is an assumption that summation works reliably. Unfortunately it is not true for IEEE floating point number where numbers are stored as approximate fraction of binary numbers. Natually, Double and Float ranges are completely broken. See numbers of issues such as scala/bug#8518, scala/bug#9875, scala/bug#9874, scala/bug#8620, scala/bug#8670, and scala/bug#10759.

I've attempted to fix the Double range in scala/collection-strawman#489 by faking it further using BigDecimal, but ultimately I was not able to overcome the fact that IEEE floats are not suited for ranges.

This removes both Float and Double ranges, as well as the fake `Integral[T]` instances that underpin their existence.
rkrzewski added a commit to rkrzewski/scala-ide that referenced this issue May 13, 2018
@rkrzewski
Floating point ranges are now deprecated
83c4f24 
See see scala/scala 340b899, scala/bug#10781
rkrzewski added a commit to rkrzewski/scala-ide that referenced this issue May 21, 2018
@rkrzewski
Floating point ranges are now deprecated
6a2afa1 
See see scala/scala 340b899, scala/bug#10781
@lrytz lrytz added this to the 2.13.0-M5 milestone May 24, 2018
@NthPortal
Copy link

More bugs:

@xuwei-k
Copy link

xuwei-k commented Sep 19, 2018

BigDecimal range would behave in predictable way.

#11152 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eed3si9n eed3si9n

Labels
library:collections library
Projects
None yet
Milestone
2.13.0-M5
Development

Successfully merging a pull request may close this issue.

bug#10781. Remove Float range and Double range [ci: last-only] eed3si9n/scala
5 participants
@lrytz @eed3si9n @xuwei-k @ritschwumm @NthPortal