Skip to content

Fix Dotty classpath #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Conversation

travisbrown
Copy link
Contributor

depsClasspath is already a classpath string, so interpolating : results in classpath arguments like this 😄:

/:h:o:m:e:/:t:r:a:v:i:s:/:.:c:o:m:p:i:l:e:r:B:e:n:c:h:m:a:r:k:/:d:e:p:s:/:c:a:t:s:-:k:e:r:n:e:l:_:2:.:1:3:-:2:.:1:.:1:.:j:a:r

I've also bumped dottyLatest and the sbt-dotty version, but would be happy to split that out into a separate PR or drop it.

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't have merge rights here /cc @retronym

Copy link
Member

@retronym retronym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@retronym retronym merged commit 9dd0d7c into scala:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants