Skip to content

Conversation

jorgarga
Copy link
Contributor

@jorgarga jorgarga commented Jul 6, 2020

This change fixes the following compiler warning:
procedure syntax is deprecated for constructors: add =, as in method definition

This change fixes the following compiler warning:
  procedure syntax is deprecated for constructors: add `=`, as in method definition
@SethTisue
Copy link
Member

wdyt about also removing the curly braces?

@jorgarga
Copy link
Contributor Author

jorgarga commented Jul 7, 2020

Thanks for your feedback!
I would leave the curly braces for different reasons:

  • They were there already (I only added the = symbol to avoid a compiler warning).
  • I am completely new to Scala and the braces help me identifying the method.
  • I am not yet familiar with code style/language idioms. So I wouldn't know what is "better".

@SethTisue
Copy link
Member

okay cool, merging as is then! thank you

@SethTisue SethTisue merged commit 7681545 into scala:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants