Skip to content

[ko] fixed typos and apply updates in English doc #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2020
Merged

[ko] fixed typos and apply updates in English doc #1746

merged 2 commits into from
Oct 5, 2020

Conversation

jhlee-young
Copy link

@jhlee-young jhlee-young commented Aug 1, 2020 •
edited
Loading

trying to keep updating Korean docs 😅

@eed3si9n
Copy link
Member

eed3si9n commented Aug 1, 2020

@scala/docs-ko review please?

@SethTisue
Copy link
Member

@chipmunklimo do you know anyone who could review this?

@eugene70
Copy link
Contributor

eugene70 commented Sep 1, 2020

I will review this ASAP.

eugene70
eugene70 suggested changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@eugene70 eugene70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have commented on several. Please consider it.

@jhlee-young
Copy link
Author

jhlee-young commented Sep 30, 2020 •
edited
Loading

sorry I'm late😅 will update soon

@jhlee-young
Copy link
Author

jhlee-young commented Oct 3, 2020 •
edited
Loading

@eugene70 could you help review this again, please? I updated😁

eugene70
eugene70 approved these changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@eugene70 eugene70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhlee-young
Copy link
Author

@eed3si9n @SethTisue good day! please help merge🤗

@som-snytt
Copy link
Contributor

som-snytt commented Oct 5, 2020 •
edited
Loading

So glad Hacktoberfest doesn't come in August in Korea.

Trusting the review and merging to relieve Seth's merge finger.

@som-snytt som-snytt merged commit 008fe2e into scala:master Oct 5, 2020
@SethTisue
Copy link
Member

thanks everybody :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@eugene70 eugene70 eugene70 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jhlee-young @eed3si9n @SethTisue @eugene70 @som-snytt