Skip to content

SIP - Sealed Types #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2021
Merged

SIP - Sealed Types #2027

merged 3 commits into from
Jul 12, 2021

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented May 18, 2021 •
edited
Loading

Jasper-M
Jasper-M reviewed May 18, 2021
View reviewed changes
@joroKr21
Copy link
Member

Is there a discussion already?

@lrytz
Copy link
Member

lrytz commented May 19, 2021

@joroKr21 https://contributors.scala-lang.org/t/sip-sealed-types/5082/12

@SethTisue SethTisue marked this pull request as draft July 9, 2021 00:29
@dwijnand
Copy link
Member Author

dwijnand commented Jul 9, 2021

Why can't this be merged?

@SethTisue SethTisue marked this pull request as ready for review July 12, 2021 14:42
@SethTisue
Copy link
Member

Sure, we can merge it. But I think the filename should be 2021-05-18-sealed-types.md (not 2020...)?

@dwijnand dwijnand merged commit 7d056bc into scala:main Jul 12, 2021
@dwijnand dwijnand deleted the sealed-types branch July 12, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Jasper-M Jasper-M Jasper-M left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dwijnand @joroKr21 @lrytz @SethTisue @Jasper-M