Fixed what I believe to be typos #2049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a small fix of what I believe was a typo
nscarcella
changed the title
then keyword
julienrf
requested changes
Jun 2, 2021
There was a problem hiding this comment.
Thank you @nscarcella, I agree with your changes but I think we should give a short explanation about Matchable (or just a link to another page of the docs that explains Matchable)
julienrf
reviewed
Jun 3, 2021
Co-authored-by: Julien Richard-Foy <julien@richard-foy.fr>
julienrf
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this
ifexpression is missing either athenor parenthesis.I'm not so sure about the other change (replacing
Anytype forMatchable), since it seems to be valid Scala code, at least on worksheets. But maybe it would be better presented this way, to avoid conflicting with this quote from other section of the book: