style guide: discourage infix #2140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plus minor assorted copyedits
|
review by @bjornregnell ? |
smarter
reviewed
Jul 24, 2021
smarter
reviewed
Jul 24, 2021
Philippus
approved these changes
Jul 24, 2021
bjornregnell
suggested changes
Jul 25, 2021
|
great edits! See my suggestions in my inline comments. I clicked "request changes" but I could just as well have clicked "Approve", as my suggestions are not religious :) |
based on review feedback from Bjorn
|
Thanks Bjorn. I took one of your suggestions — the others are good as well but remain as future work for somebody. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plus minor assorted copyedits