Skip to content

[zh-cn] Chinese Simple translation for the new overview page. #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

dongxuwang
Copy link
Member

No description provided.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

- category: 标准库
description: "涵盖Scala标准库的参考与概览"
overviews:
- title: Scala 容器
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current page says "Scala的容器类" so changing this to "Scala 容器" hopefully is not controversial because it's closer to the original "Scala Collections" in https://docs.scala-lang.org/overviews/index.html

The only potential thing to note is the whitespace after Scala, which I personally prefer but does not seem to be the convention applied consistently.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.

  1. The reason that keeping "Scala 容器" is because not just what you're referring, but also there has been an additional description "Scala 的容器库" which is demonstrating the title in detail. Thus the title needs to be simpler and conciser.

  2. Yes, totally agree the translation needs to be kept consistent. I added spaces to wrap the English terminologies and numbers in the translation and re-pushed.

@eed3si9n eed3si9n merged commit 3cb1151 into scala:main Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants